From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MbhU9-0003Tk-8k for mharc-grub-devel@gnu.org; Thu, 13 Aug 2009 17:05:21 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MbhU6-0003Or-HY for grub-devel@gnu.org; Thu, 13 Aug 2009 17:05:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MbhU1-0003Jw-My for grub-devel@gnu.org; Thu, 13 Aug 2009 17:05:18 -0400 Received: from [199.232.76.173] (port=46692 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MbhU1-0003Jr-Fr for grub-devel@gnu.org; Thu, 13 Aug 2009 17:05:13 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:48248 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MbhU0-00037E-Su for grub-devel@gnu.org; Thu, 13 Aug 2009 17:05:13 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MbhTy-0000Y4-RH for grub-devel@gnu.org; Thu, 13 Aug 2009 23:05:11 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MbhTu-000648-G7 for grub-devel@gnu.org; Thu, 13 Aug 2009 23:05:06 +0200 Date: Thu, 13 Aug 2009 23:05:06 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090813210506.GS22130@thorin> References: <20090812003800.GC8561@thorin> <20090813203736.GH22130@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [RFT,PATCH] Move embedding to appropriate partmap files X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2009 21:05:19 -0000 On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> We may want to embed more in the future. Actually I think it's not > >> ad-hoc. Basically partition map defines a function which gives back > >> the sectors available for embedding. > > > > Is embedding useful elsewhere? > Yes. Consider a world of checksummed filesystems. In such world you > can't change the contents of the file by just writing to its blocklist > since it will break the checksum. Similar problems exist with RAIDs > and LVMs. On some systems we can't put grub-env in a file. For these > cases we can embed grub-env somewhere where we can write it with ease Ok. Feel free to use partmap/ then. But please make sure #ifdefs only enable those functions where they are going to be used. That'd be GRUB_MACHINE_PCBIOS for now, if later code in other ports relies on them, this can be changed. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."