From: Karl Wiberg <kha@virtutech.com>
To: Erik Sandberg <mandolaerik@gmail.com>
Cc: Catalin Marinas <catalin.marinas@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Work around performance bug in subprocess.Popen.communicate()
Date: Fri, 14 Aug 2009 10:12:20 +0200 [thread overview]
Message-ID: <20090814081220.GA24722@lux.e.vtech> (raw)
In-Reply-To: <e87cdfda0908140026x21b8aad3x82417d4b1c8016f4@mail.gmail.com>
On 2009-08-14 09:26:06 +0200, Erik Sandberg wrote:
> Wouldn't it be better to only use the write() workaround when
> sys.version indicates that the Python bug may be present, and use
> communicate() properly otherwise?
In my opinion: no. The workaround has no negative effect (since we
know that git is well-behaved). Making it conditional would only make
the code more complex, without gaining us anything.
--
Karl Wiberg, Virtutech
prev parent reply other threads:[~2009-08-14 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 9:36 [PATCH] Work around performance bug in subprocess.Popen.communicate() Karl Wiberg
2009-07-31 11:27 ` Catalin Marinas
2009-08-04 8:51 ` Karl Wiberg
2009-08-13 22:18 ` Catalin Marinas
2009-08-14 6:21 ` Karl Wiberg
2009-08-14 7:26 ` Erik Sandberg
2009-08-14 8:12 ` Karl Wiberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090814081220.GA24722@lux.e.vtech \
--to=kha@virtutech.com \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=mandolaerik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.