Re: [PATCH 8/9] OMAP2: add board file for Nokia N800 and N810

[Tony Lindgren <tony@atomide.com>]

* Kalle Valo <kalle.valo@iki.fi> [090814 09:01]:
> Russell King - ARM Linux <linux@arm.linux.org.uk> writes:
> 
> > On Tue, Aug 11, 2009 at 12:55:58PM +0300, Tony Lindgren wrote:
> >> +#include <mach/gpio.h>
> >
> > linux/gpio.h
> >
> >> +#include <mach/io.h>
> >
> > linux/io.h
> 
> Thanks, will fix.
> 
> >> +static struct musb_hdrc_platform_data tusb_data = {
> >> +	.mode		= BOARD_MODE,
> >> +	.set_power	= tusb_set_power,
> >> +	.set_clock	= tusb_set_clock,
> >> +	.min_power	= 25,	/* x2 = 50 mA drawn from VBUS as peripheral */
> >> +	.power		= 100,	/* Max 100 mA VBUS for host mode */
> >> +	.clock		= "osc_ck",
> >
> > Still passing clock names around?
> 
> Sorry, I'm not familiar with this. How should I fix it?

This should be fixed with the clkdev alias, see omap24xx_clks[].

But we need to check how the fix affects other platforms for
drivers/usb/musb/musb_core.c and send the patch via linux-usb.

Maybe take a quick look, and if it looks like a bigger change,
then leave out the tusb_data for now and let's do it in a separate
patch?

> Tony, do you want me to send v2?

Sure, it's best that you update it.

Tony