From: Arnd Bergmann <arnd@arndb.de>
To: Stefani Seibold <stefani@seibold.net>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Amerigo Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCH 5/6] new kfifo API v0.3 - add kfifo_skip, kfifo_from_user and kfifo_to_user
Date: Fri, 14 Aug 2009 14:25:42 +0200 [thread overview]
Message-ID: <200908141425.42220.arnd@arndb.de> (raw)
In-Reply-To: <1250250286.19690.96.camel@wall-e>
On Friday 14 August 2009, Stefani Seibold wrote:
> This is patch 5/6 of the new kfifo API:
> kfifo_reset_out() to lockless save discard the fifo output
> Add kfifo_skip() to skip a number of output bytes
> Add kfifo_from_user() to copy user space data into the fifo
> Add kfifo_to_user() to copy fifo data to user space
> Do some code reorg
kfifo_skip is missing a comment regarding what it does,
and as with the other patches, the description should
line out why this is done, not what you do.
> Signed-off-by: Stefani Seibold <stefani@seibold.net>
Otherwise,
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2009-08-14 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 11:44 [PATCH 5/6] new kfifo API v0.3 - add kfifo_skip, kfifo_from_user and kfifo_to_user Stefani Seibold
2009-08-14 12:25 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908141425.42220.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.