Re: [PATCH] icom: bit and/or confusion?

[Greg KH <gregkh@suse.de>]

On Fri, Aug 14, 2009 at 02:02:34PM +0200, Roel Kluin wrote:
> Previously, if any bit other than CMD_SND_BREAK was set, CMD_SND_BREAK
> was not unset.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> I think meant was: If CMD_SND_BREAK is set, unset it. Correct?
> 
> // vi drivers/serial/icom.h +137
> #define CMD_SND_BREAK                0x04
> 
> diff --git a/drivers/serial/icom.c b/drivers/serial/icom.c
> index cd1b6a4..060f4e3 100644
> --- a/drivers/serial/icom.c
> +++ b/drivers/serial/icom.c
> @@ -617,7 +617,7 @@ static void shutdown(struct icom_port *icom_port)
>  	 * disable break condition
>  	 */
>  	cmdReg = readb(&icom_port->dram->CmdReg);
> -	if ((cmdReg | CMD_SND_BREAK) == CMD_SND_BREAK) {
> +	if (cmdReg & CMD_SND_BREAK) {

This change is the exact same thing, right?  How is the original
incorrect here?

thanks,

greg k-h