From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH 4/8] powerpc/qe&cpm: Implement static inline stubs for non-QE/CPM builds Date: Mon, 17 Aug 2009 17:53:37 +0400 Message-ID: <20090817135337.GA6251@oksana.dev.rtsoft.ru> References: <20090814222453.GA9568@oksana.dev.rtsoft.ru> <20090814222549.GD14458@oksana.dev.rtsoft.ru> Reply-To: avorontsov@ru.mvista.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: spi-devel-general@lists.sourceforge.net, Andrew Morton , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org To: David Brownell Return-path: Content-Disposition: inline In-Reply-To: <20090814222549.GD14458@oksana.dev.rtsoft.ru> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org List-Id: linux-spi.vger.kernel.org T24gU2F0LCBBdWcgMTUsIDIwMDkgYXQgMDI6MjU6NDlBTSArMDQwMCwgQW50b24gVm9yb250c292 IHdyb3RlOgpbLi4uLl0KPiArI2lmZGVmIENPTkZJR19DUE0KPiAgaW50IGNwbV9jb21tYW5kKHUz MiBjb21tYW5kLCB1OCBvcGNvZGUpOwo+ICsjZWxzZQo+ICtzdGF0aWMgaW5saW5lIGludCBjcG1f Y29tbWFuZCh1MzIgY29tbWFuZCwgdTggb3Bjb2RlKQo+ICt7Cj4gKwlyZXR1cm4gLUVOT1NZUzsK PiArfQo+ICsjZW5kaWYgLyogQ09ORklHX0NQTSAqLwoKSXQgYXBwZXJzIHRoYXQgZnNsX3FlX3Vk Yy5oIGRlZmluZXMgaXRzIG93biBpbmxpbmVkIHZlcnNpb24sIGFuZCBzbwpmc2xfcWVfdWRjLmMn cyBidWlsZCBicmVha3M6CgpJbiBmaWxlIGluY2x1ZGVkIGZyb20gZHJpdmVycy91c2IvZ2FkZ2V0 L2ZzbF9xZV91ZGMuYzo0NDoKZnNsX3FlX3VkYy5oOjQzMjogZXJyb3I6IHJlZGVmaW5pdGlvbiBv ZiDigJhxZV9pc3N1ZV9jbWTigJkKYXJjaC9wb3dlcnBjL2luY2x1ZGUvYXNtL3FlLmg6MTUzOiBl cnJvcjogcHJldmlvdXMgZGVmaW5pdGlvbiBvZiDigJhxZV9pc3N1ZV9jbWTigJkgd2FzIGhlcmUK CkkgZGlkbid0IG5vdGljZSB0aGF0IGVhcmxpZXIgYmVjYXVzZSBVU0JfR0FER0VUX0ZTTF9RRSBp c24ndCBlbmFibGVkCmluIGFueSBkZWZjb25maWcuCgpJJ2xsIHNlbmQgdjIgc29vbi4KClRoYW5r cywKCi0tIApBbnRvbiBWb3JvbnRzb3YKZW1haWw6IGNib3VhdG1haWxydUBnbWFpbC5jb20KaXJj Oi8vaXJjLmZyZWVub2RlLm5ldC9iZDIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXhwcGMtZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlz dHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMt ZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 05F0CB7067 for ; Mon, 17 Aug 2009 23:53:43 +1000 (EST) Received: from buildserver.ru.mvista.com (unknown [213.79.90.228]) by ozlabs.org (Postfix) with ESMTP id 76766DDD0B for ; Mon, 17 Aug 2009 23:53:41 +1000 (EST) Date: Mon, 17 Aug 2009 17:53:37 +0400 From: Anton Vorontsov To: David Brownell Subject: Re: [PATCH 4/8] powerpc/qe&cpm: Implement static inline stubs for non-QE/CPM builds Message-ID: <20090817135337.GA6251@oksana.dev.rtsoft.ru> References: <20090814222453.GA9568@oksana.dev.rtsoft.ru> <20090814222549.GD14458@oksana.dev.rtsoft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20090814222549.GD14458@oksana.dev.rtsoft.ru> Cc: spi-devel-general@lists.sourceforge.net, Andrew Morton , linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Reply-To: avorontsov@ru.mvista.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sat, Aug 15, 2009 at 02:25:49AM +0400, Anton Vorontsov wrote: [....] > +#ifdef CONFIG_CPM > int cpm_command(u32 command, u8 opcode); > +#else > +static inline int cpm_command(u32 command, u8 opcode) > +{ > + return -ENOSYS; > +} > +#endif /* CONFIG_CPM */ It appers that fsl_qe_udc.h defines its own inlined version, and so fsl_qe_udc.c's build breaks: In file included from drivers/usb/gadget/fsl_qe_udc.c:44: fsl_qe_udc.h:432: error: redefinition of ‘qe_issue_cmd’ arch/powerpc/include/asm/qe.h:153: error: previous definition of ‘qe_issue_cmd’ was here I didn't notice that earlier because USB_GADGET_FSL_QE isn't enabled in any defconfig. I'll send v2 soon. Thanks, -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2