From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Md2m2-0005it-6G for mharc-grub-devel@gnu.org; Mon, 17 Aug 2009 10:01:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Md2m0-0005he-Ph for grub-devel@gnu.org; Mon, 17 Aug 2009 10:01:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Md2lv-0005dd-Gj for grub-devel@gnu.org; Mon, 17 Aug 2009 10:01:19 -0400 Received: from [199.232.76.173] (port=48048 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Md2lu-0005dN-Km for grub-devel@gnu.org; Mon, 17 Aug 2009 10:01:15 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:36904 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Md2lt-0004u3-WB for grub-devel@gnu.org; Mon, 17 Aug 2009 10:01:14 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Md2lr-0005dk-TN for grub-devel@gnu.org; Mon, 17 Aug 2009 16:01:12 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Md2lr-0000NS-8w for grub-devel@gnu.org; Mon, 17 Aug 2009 16:01:11 +0200 Date: Mon, 17 Aug 2009 16:01:11 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090817140111.GO32551@thorin> References: <20090807121257.GA7839@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Reimplement 10_freebsd.in using 10_linux.in X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2009 14:01:21 -0000 On Sun, Aug 16, 2009 at 09:29:08PM +0200, Vladimir 'phcoder' Serbinenko wrote: > As discussed on IRC this patch has problems on FreeBSD. > Among them > 1) stat and readlink are different. Does anyone have an idea how to > make scripts always use right syntax? AFAIK a custom autoconf snippet is the only way. Do you know how to reliably identify GNU-incompatible readlink? I'm not sure what "readlink -f /" will do on FreeBSD. > - if path=`readlink -f $path` ; then : ; else > + if path=`realpath $path` ; then : ; else Note that this introduces an external dependency on GNU systems (readlink is part of coreutils), which better be avoided (specially since the version of realpath commonly used there has a problematic license). > 2) "FreeBSD, kFreeBSD ..." isn't what FreeBSD user expects. Ok. > 3) Version isn't detected correctly. Since this part is not in your patch, can you explain the problem? > 5) device.hints are forgotten Ok. > 4) Doesn't use UUID > 6) Doesn't support ZFS These two are in the previous version too, so I'd fix/merge them separately (increasing commit granularity is a good thing). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."