From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Md2sT-0002kx-Us for mharc-grub-devel@gnu.org; Mon, 17 Aug 2009 10:08:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Md2sR-0002jy-SS for grub-devel@gnu.org; Mon, 17 Aug 2009 10:08:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Md2sN-0002ax-3q for grub-devel@gnu.org; Mon, 17 Aug 2009 10:07:59 -0400 Received: from [199.232.76.173] (port=43278 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Md2sM-0002ak-BU for grub-devel@gnu.org; Mon, 17 Aug 2009 10:07:54 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:53951 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Md2sL-0005uM-KL for grub-devel@gnu.org; Mon, 17 Aug 2009 10:07:53 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Md2sK-0005eN-78 for grub-devel@gnu.org; Mon, 17 Aug 2009 16:07:52 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Md2sJ-0000Ov-JS for grub-devel@gnu.org; Mon, 17 Aug 2009 16:07:51 +0200 Date: Mon, 17 Aug 2009 16:07:51 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090817140751.GQ32551@thorin> References: <20090817133230.GF32551@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] make search faster by first trying without module autoloading X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2009 14:08:00 -0000 On Mon, Aug 17, 2009 at 03:46:40PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 17, 2009 at 3:32 PM, Robert Millan wrote: > > On Fri, Aug 14, 2009 at 05:58:20PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Hello. When search encounters an unknown filesystem or filesystem > >> without partition it triggers fs module autoload which takes > >> noticeable time. To improve the situation I propose (after discussing > >> with Robert Millan) to first search without autoloading modules if we > >> need to find only one device (with --set ) and retry with autoloading > >> if without autoloading the search failed. Additionally I modify > >> grub-mkconfig to load correct module manually before issuing search to > >> decrease booting time if filesystem is different that our boot one. > > > > Looks good to me.  Also, I think Yves suggestion is a good idea. > > > In this case 'var' stands for a 'variable' which is sensible in this > case since it's environment variable name. Ah, ok. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."