From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Barry Song <21cnbao@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH V2 2/3] add set_tdm_slot in tdm dai to define the relationship between audio channel and tdm slot
Date: Mon, 17 Aug 2009 18:50:10 +0100 [thread overview]
Message-ID: <20090817175010.GA19707@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1250137511-24034-1-git-send-email-21cnbao@gmail.com>
On Thu, Aug 13, 2009 at 12:25:11PM +0800, Barry Song wrote:
> For ad1938, the audio channel n just uses slot n, but for ad1836, it's
> different, channel 0 uses slot 0, channel 1 uses slot 4, channels 2 uses
> slot1, ... So add set_tdm_slot entry and use the mask field to define
> the relationship between audio channel and slot number.
I think what you're trying to describe here is that the device is
expecting to see all the left channels on the bus followed by all the
right channels? This is the normal case for I2S TDM so no unusual
configuration is required in order to implement it.
I really don't think we should have Blackfin implementing a different
API here - it makes the TDM slot API much harder to use. Instead we
should have a consistent API between all devices. This may mean that we
need to extend the APIs here.
next prev parent reply other threads:[~2009-08-17 17:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 4:25 [PATCH V2 2/3] add set_tdm_slot in tdm dai to define the relationship between audio channel and tdm slot Barry Song
2009-08-17 17:50 ` Mark Brown [this message]
2009-08-18 2:53 ` Barry Song
2009-08-18 13:11 ` Mark Brown
2009-08-19 1:34 ` Barry Song
2009-08-19 11:34 ` Mark Brown
2009-08-20 2:37 ` Barry Song
2009-08-28 12:42 ` Mark Brown
2009-08-31 3:14 ` Barry Song
2009-08-31 12:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090817175010.GA19707@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=21cnbao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.