From: Michael Gorven <michael@gorven.za.net>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Crypto Review
Date: Mon, 17 Aug 2009 18:21:40 +0200 [thread overview]
Message-ID: <200908171821.40623.michael@gorven.za.net> (raw)
In-Reply-To: <d7ead6de0908170907y19fd084cr81b3a1b02f12316d@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
On Monday 17 August 2009 18:07:07 Vladimir 'phcoder' Serbinenko wrote:
> Diff would be nice. Because not all developpers (including me) are
> familiar with bzr and it would take time for me to find out how to
> request specifically the patch I want to review. Additionally not
> posting diff makes inline reply impossible. It's fine to ask people to
> test your bzr but for review patch is prefered.
I attached diffs for three of the modules, since comments on the cipher/hash
interface and style will affect all the modules and so I didn't see much
point in reviewing all of them right now. If you'd like a diff of everything
I can do that though.
Michael
--
http://michael.gorven.za.net
PGP Key ID 1E016BE8
S/MIME Key ID AAF09E0E
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]
next prev parent reply other threads:[~2009-08-17 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 15:51 Crypto Review Michael Gorven
2009-08-17 16:07 ` Vladimir 'phcoder' Serbinenko
2009-08-17 16:21 ` Michael Gorven [this message]
2009-08-17 18:28 ` Vladimir 'phcoder' Serbinenko
2009-08-17 16:19 ` Vladimir 'phcoder' Serbinenko
2009-08-17 17:15 ` Duboucher Thomas
2009-08-18 7:14 ` Michael Gorven
2009-08-18 16:18 ` Duboucher Thomas
2009-08-18 19:29 ` Michael Gorven
2009-08-18 20:36 ` Duboucher Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908171821.40623.michael@gorven.za.net \
--to=michael@gorven.za.net \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.