From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Md4yC-0006qQ-7T for mharc-grub-devel@gnu.org; Mon, 17 Aug 2009 12:22:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Md4yA-0006po-2P for grub-devel@gnu.org; Mon, 17 Aug 2009 12:22:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Md4y9-0006pC-AM for grub-devel@gnu.org; Mon, 17 Aug 2009 12:22:01 -0400 Received: from [199.232.76.173] (port=36727 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Md4y9-0006p8-5t for grub-devel@gnu.org; Mon, 17 Aug 2009 12:22:01 -0400 Received: from mammon.mene.za.net ([78.46.253.195]:53108 helo=mail.mene.za.net) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Md4y7-0004Bd-T6 for grub-devel@gnu.org; Mon, 17 Aug 2009 12:22:00 -0400 Received: from mail.mene.za.net (localhost [127.0.0.1]) by mail.mene.za.net (Postfix) with ESMTP id 04AB27E68E for ; Mon, 17 Aug 2009 18:21:57 +0200 (SAST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gorven.za.net; h=from:to :subject:date:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; s=alpha; bh=W/ONzr5dKVLec tLq2ZueS5crVBo=; b=BDCE+BxDDTunBhIdpYJseR4ZyA6ZtW9/Z77lGy4c3kI5y 5bDvJj5y/K203GSsvj//mVTs0ujTQyCSeE16gGaqVpg+jwxyQSmJ8jJGe/16n8WY YLwC11nS/l2QnzIXdD7Dcjssrwli1vBHj9NTJEKc6CX/jjEF5j8LI+ZLbL0ZxE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gorven.za.net; h=from:to :subject:date:references:in-reply-to:mime-version:content-type :content-transfer-encoding:message-id; q=dns; s=alpha; b=hzCXlCq YkALhOmW7p9e2m6WcilOqTliKUyfi9A5G0qFmkRhY8PU37hGSK3JuDGKX7do8WXe i2ntFcrlWQrELadk0/9v/CgjIb5TruonLpbJLyavl2x+iCVojKGmsNW50PyZWZJn /J2qQegIfMmDnN6wFagB+UUPLK7phlnoezMs= Received: from molech (dsl-241-125-225.telkomadsl.co.za [41.241.125.225]) by mail.mene.za.net (Postfix) with ESMTPSA id ACA847E118 for ; Mon, 17 Aug 2009 18:21:55 +0200 (SAST) From: Michael Gorven To: The development of GRUB 2 Date: Mon, 17 Aug 2009 18:21:40 +0200 User-Agent: KMail/1.9.10 References: <200908171751.57668.michael@gorven.za.net> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3776224.oxXBPP5WKW"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200908171821.40623.michael@gorven.za.net> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Crypto Review X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2009 16:22:02 -0000 --nextPart3776224.oxXBPP5WKW Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Monday 17 August 2009 18:07:07 Vladimir 'phcoder' Serbinenko wrote: > Diff would be nice. Because not all developpers (including me) are > familiar with bzr and it would take time for me to find out how to > request specifically the patch I want to review. Additionally not > posting diff makes inline reply impossible. It's fine to ask people to > test your bzr but for review patch is prefered. I attached diffs for three of the modules, since comments on the cipher/has= h=20 interface and style will affect all the modules and so I didn't see much=20 point in reviewing all of them right now. If you'd like a diff of everythin= g=20 I can do that though. Michael =2D-=20 http://michael.gorven.za.net PGP Key ID 1E016BE8 S/MIME Key ID AAF09E0E --nextPart3776224.oxXBPP5WKW Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASomDlIOxIz1l+OmhAQrKcA/9Ex71FrwipSoMmpQVo9q+TUwR9CiS141t kpMTkvWOR0kbyqzQq7kcLC9GeMpA7Pqwwj1qww/0sfvyNc1CHpkjl1VMtPdCBV0k 31+JbEL3w0nUVCbLEJVN8aieM/lLoFOWf1cUDzvzNvj/FqlSDRbP+8NVyNPDffGI j/GQ83JYrF/hoKCvNnk2iREN1wqR0XHXMQ2WArByJlL1hUq8ObnN52YVdhe8yNbz zwWxZoISKZhCB6e5auHZ+Na2IAP/DInAtPzUnOEMykKIrpY7Z7uCRk2zCVbVZYYw K8jbAPO2w2zn7a5bhCFkbU/ROT3UYIZ5UIsg+q7ajxuN8wzZFF4riu75cSYpmgT5 Wp/qEC3snY4EKspydvmLD68J+PydjRwosR8rsUtL1/SFTDB37V1lRTbCY3J79T7O XYI4Y/irDzln0sLBKVz9iljocQoG7curlcIG+nWl7aZ759ULW3eCzaHiE8JIRTI7 uamtT5jmJaOXp3EVxJCVtsbOOZWQOLRRR4OgOAdBiI9R3E7XHUnDSvoRvJxEfLDQ DqogCsWmgj7AIYuENBYHaWE2VSPqDVAIlNWO2eneTnbjmNyoYgnQ6Oho+ECynUqR 6ZtS5bu50LvQ3Bf+nhftynB71M+Hj7caw5ebD/aDevFlDTkVn8b9no76p3g0dBwG kjv+KEmTojE= =3X3m -----END PGP SIGNATURE----- --nextPart3776224.oxXBPP5WKW--