diff for duplicates of <20090818023438.GB7958@localhost> diff --git a/a/1.txt b/N1/1.txt index b4f3027..09a833a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,13 +7,13 @@ On Mon, Aug 17, 2009 at 10:33:54PM +0800, Minchan Kim wrote: > >> > Wu Fengguang wrote: > >> > > On Fri, Aug 07, 2009 at 05:09:55AM +0800, Jeff Dike wrote: > >> > >> Side question - -> >> > >> Is there a good reason for this to be in shrink_active_list() +> >> > >> A Is there a good reason for this to be in shrink_active_list() > >> > >> as opposed to __isolate_lru_page? > >> > >> -> >> > >> if (unlikely(!page_evictable(page, NULL))) { -> >> > >> putback_lru_page(page); -> >> > >> continue; -> >> > >> } +> >> > >> A A A A A if (unlikely(!page_evictable(page, NULL))) { +> >> > >> A A A A A A A A A putback_lru_page(page); +> >> > >> A A A A A A A A A continue; +> >> > >> A A A A A } > >> > >> > >> > >> Maybe we want to minimize the amount of code under the lru lock or > >> > >> avoid duplicate logic in the isolate_page functions. @@ -67,29 +67,29 @@ Fengguang > > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> > > --- > > -> > --- linux.orig/mm/rmap.c 2009-08-16 19:11:13.000000000 +0800 -> > +++ linux/mm/rmap.c 2009-08-16 19:22:46.000000000 +0800 +> > --- linux.orig/mm/rmap.c A A A A 2009-08-16 19:11:13.000000000 +0800 +> > +++ linux/mm/rmap.c A A 2009-08-16 19:22:46.000000000 +0800 > > @@ -358,6 +358,7 @@ static int page_referenced_one(struct pa -> > */ -> > if (vma->vm_flags & VM_LOCKED) { -> > *mapcount = 1; /* break early from loop */ -> > + *vm_flags |= VM_LOCKED; -> > goto out_unmap; -> > } +> > A A A A */ +> > A A A A if (vma->vm_flags & VM_LOCKED) { +> > A A A A A A A A *mapcount = 1; A /* break early from loop */ +> > + A A A A A A A *vm_flags |= VM_LOCKED; +> > A A A A A A A A goto out_unmap; +> > A A A A } > > > > @@ -482,6 +483,8 @@ static int page_referenced_file(struct p -> > } +> > A A A A } > > -> > spin_unlock(&mapping->i_mmap_lock); -> > + if (*vm_flags & VM_LOCKED) -> > + referenced = 0; -> > return referenced; -> > } +> > A A A A spin_unlock(&mapping->i_mmap_lock); +> > + A A A if (*vm_flags & VM_LOCKED) +> > + A A A A A A A referenced = 0; +> > A A A A return referenced; +> > A } > > > > > > -- > > To unsubscribe, send a message with 'unsubscribe linux-mm' in -> > the body to majordomo@kvack.org. For more info on Linux MM, +> > the body to majordomo@kvack.org. A For more info on Linux MM, > > see: http://www.linux-mm.org/ . > > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> > > @@ -99,3 +99,9 @@ Fengguang > -- > Kind regards, > Minchan Kim + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index ea03483..10fa9ac 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -38,13 +38,13 @@ "> >> > Wu Fengguang wrote:\n" "> >> > > On Fri, Aug 07, 2009 at 05:09:55AM +0800, Jeff Dike wrote:\n" "> >> > >> Side question -\n" - "> >> > >> \302\240Is there a good reason for this to be in shrink_active_list()\n" + "> >> > >> A Is there a good reason for this to be in shrink_active_list()\n" "> >> > >> as opposed to __isolate_lru_page?\n" "> >> > >>\n" - "> >> > >> \302\240 \302\240 \302\240 \302\240 \302\240if (unlikely(!page_evictable(page, NULL))) {\n" - "> >> > >> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240putback_lru_page(page);\n" - "> >> > >> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240continue;\n" - "> >> > >> \302\240 \302\240 \302\240 \302\240 \302\240}\n" + "> >> > >> A A A A A if (unlikely(!page_evictable(page, NULL))) {\n" + "> >> > >> A A A A A A A A A putback_lru_page(page);\n" + "> >> > >> A A A A A A A A A continue;\n" + "> >> > >> A A A A A }\n" "> >> > >>\n" "> >> > >> Maybe we want to minimize the amount of code under the lru lock or\n" "> >> > >> avoid duplicate logic in the isolate_page functions.\n" @@ -98,29 +98,29 @@ "> > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>\n" "> > ---\n" "> >\n" - "> > --- linux.orig/mm/rmap.c \302\240 \302\240 \302\240 \302\2402009-08-16 19:11:13.000000000 +0800\n" - "> > +++ linux/mm/rmap.c \302\240 \302\240 2009-08-16 19:22:46.000000000 +0800\n" + "> > --- linux.orig/mm/rmap.c A A A A 2009-08-16 19:11:13.000000000 +0800\n" + "> > +++ linux/mm/rmap.c A A 2009-08-16 19:22:46.000000000 +0800\n" "> > @@ -358,6 +358,7 @@ static int page_referenced_one(struct pa\n" - "> > \302\240 \302\240 \302\240 \302\240 */\n" - "> > \302\240 \302\240 \302\240 \302\240if (vma->vm_flags & VM_LOCKED) {\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240*mapcount = 1; \302\240/* break early from loop */\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 *vm_flags |= VM_LOCKED;\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240goto out_unmap;\n" - "> > \302\240 \302\240 \302\240 \302\240}\n" + "> > A A A A */\n" + "> > A A A A if (vma->vm_flags & VM_LOCKED) {\n" + "> > A A A A A A A A *mapcount = 1; A /* break early from loop */\n" + "> > + A A A A A A A *vm_flags |= VM_LOCKED;\n" + "> > A A A A A A A A goto out_unmap;\n" + "> > A A A A }\n" "> >\n" "> > @@ -482,6 +483,8 @@ static int page_referenced_file(struct p\n" - "> > \302\240 \302\240 \302\240 \302\240}\n" + "> > A A A A }\n" "> >\n" - "> > \302\240 \302\240 \302\240 \302\240spin_unlock(&mapping->i_mmap_lock);\n" - "> > + \302\240 \302\240 \302\240 if (*vm_flags & VM_LOCKED)\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 referenced = 0;\n" - "> > \302\240 \302\240 \302\240 \302\240return referenced;\n" - "> > \302\240}\n" + "> > A A A A spin_unlock(&mapping->i_mmap_lock);\n" + "> > + A A A if (*vm_flags & VM_LOCKED)\n" + "> > + A A A A A A A referenced = 0;\n" + "> > A A A A return referenced;\n" + "> > A }\n" "> >\n" "> >\n" "> > --\n" "> > To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "> > the body to majordomo@kvack.org. \302\240For more info on Linux MM,\n" + "> > the body to majordomo@kvack.org. A For more info on Linux MM,\n" "> > see: http://www.linux-mm.org/ .\n" "> > Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>\n" "> >\n" @@ -129,6 +129,12 @@ "> \n" "> -- \n" "> Kind regards,\n" - > Minchan Kim + "> Minchan Kim\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -ec1fe4572bb27dc4ac8abd19ae2457200a5460cfbd84edbc3c2f32243688c563 +9430e582595349f61b0d3485a9b331147ef6d77ba84067606415c00eebd1ad3e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.