From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751522AbZHRFAm (ORCPT ); Tue, 18 Aug 2009 01:00:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751436AbZHRFAl (ORCPT ); Tue, 18 Aug 2009 01:00:41 -0400 Received: from 1wt.eu ([62.212.114.60]:44432 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751364AbZHRFAk (ORCPT ); Tue, 18 Aug 2009 01:00:40 -0400 Date: Tue, 18 Aug 2009 07:00:27 +0200 From: Willy Tarreau To: Jens Axboe Cc: Miklos Szeredi , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] splice: update mtime and atime on files Message-ID: <20090818050027.GE11624@1wt.eu> References: <20090815064241.GE12579@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090815064241.GE12579@kernel.dk> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 15, 2009 at 08:42:41AM +0200, Jens Axboe wrote: > On Fri, Aug 14 2009, Miklos Szeredi wrote: > > From: Miklos Szeredi > > > > Splice should update the modification and access times on regular > > files just like read and write. Not updating mtime will confuse > > backup tools, etc... > > > > This patch only adds the time updates for regular files. For pipes > > and other special files that splice touches the need for updating the > > times is less clear. Let's discuss and fix that separately. > > Thanks Miklos, I've queued this one up. wouldn't it make sense to send that to stable too ? The patch is not intrusive and looks like a fix to me. Willy