From: Jens Axboe <jens.axboe@oracle.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] splice: update mtime and atime on files
Date: Tue, 18 Aug 2009 10:35:48 +0200 [thread overview]
Message-ID: <20090818083547.GK12579@kernel.dk> (raw)
In-Reply-To: <20090818050027.GE11624@1wt.eu>
On Tue, Aug 18 2009, Willy Tarreau wrote:
> On Sat, Aug 15, 2009 at 08:42:41AM +0200, Jens Axboe wrote:
> > On Fri, Aug 14 2009, Miklos Szeredi wrote:
> > > From: Miklos Szeredi <mszeredi@suse.cz>
> > >
> > > Splice should update the modification and access times on regular
> > > files just like read and write. Not updating mtime will confuse
> > > backup tools, etc...
> > >
> > > This patch only adds the time updates for regular files. For pipes
> > > and other special files that splice touches the need for updating the
> > > times is less clear. Let's discuss and fix that separately.
> >
> > Thanks Miklos, I've queued this one up.
>
> wouldn't it make sense to send that to stable too ? The patch is not
> intrusive and looks like a fix to me.
It doesn't really meet the stable criteria, as it's not a security issue
nor does it crash the kernel.
--
Jens Axboe
next prev parent reply other threads:[~2009-08-18 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 15:05 [PATCH] splice: update mtime and atime on files Miklos Szeredi
2009-08-15 6:42 ` Jens Axboe
2009-08-18 5:00 ` Willy Tarreau
2009-08-18 8:35 ` Jens Axboe [this message]
2009-08-18 8:46 ` Willy Tarreau
2009-08-18 8:50 ` Jens Axboe
2009-08-18 11:59 ` Miklos Szeredi
2009-08-19 8:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818083547.GK12579@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.