From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: randy.dunlap@oracle.com, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, akpm@linux-foundation.org,
nhorman@tuxdriver.com, rostedt@goodmis.org
Subject: Re: [PATCH -next] trace_skb: fix build when CONFIG_NET is not enabled
Date: Tue, 18 Aug 2009 14:13:52 +0200 [thread overview]
Message-ID: <20090818121352.GA20286@elte.hu> (raw)
In-Reply-To: <20090817.170337.139340805.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> From: Ingo Molnar <mingo@elte.hu>
> Date: Tue, 18 Aug 2009 01:06:54 +0200
>
> > ... but these are the wrong patches, they should be removed or
> > reverted and redone properly.
>
> Given the number of users of net-next-2.6, removal via rebasing
> is simply not an option. The other two posibilities, sure...
>
> > It's not just about keeping kernel/trace/* changes in the
> > tracing tree (which we can relax on-demand given agreement),
> > it's that these patches are also _wrong_ and we cannot relax
> > anything about that.
>
> Why don't we give Neil a chance to review the situation and fix
> things up?
>
> If revert is the final decision, that's fine, I'll revert
> everything.
>
> But in the mean time at least give Neil a chance to read all of
> your feedback and coordinate a way to fix things with everyone.
Oh, sure. Conversion to TRACE_EVENT() is equivalent to the revert
of the current patches plus introduction of the TRACE_EVENT()
defines.
Ingo
prev parent reply other threads:[~2009-08-18 12:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 20:37 [PATCH -next] trace_skb: fix build when CONFIG_NET is not enabled Randy Dunlap
2009-08-17 21:58 ` Ingo Molnar
2009-08-17 22:33 ` David Miller
2009-08-17 22:47 ` Ingo Molnar
2009-08-17 22:59 ` David Miller
2009-08-17 23:03 ` Ingo Molnar
2009-08-17 23:00 ` Ingo Molnar
2009-08-17 23:00 ` David Miller
2009-08-17 23:06 ` Ingo Molnar
2009-08-18 0:03 ` David Miller
2009-08-18 12:13 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090818121352.GA20286@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=randy.dunlap@oracle.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.