diff for duplicates of <20090818214449.GA12848@oksana.dev.rtsoft.ru> diff --git a/a/1.txt b/N1/1.txt index d029ed3..73940f2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -32,7 +32,7 @@ We can't tell if the chip was actually found. M25Px0 chips can be JEDEC and non-JEDEC, e.g. Nymonyx manufacturing "M25P80" chips in two variants: "The RDID instruction is available only -for parts made with Technology T9HX (0.11μm), ..." +for parts made with Technology T9HX (0.11μm), ..." Most (but not all) non-JEDEC EEPROMs will return "0" for RDID opcode though (in that case warning is misleading). And for the chips that @@ -53,9 +53,9 @@ CAT25 chips. > There's a new error case of course: new-style but data->type > doesn't match id->name. [...] -> > + if (i == ARRAY_SIZE(m25p_ids) - 1) { +> > + if (i = ARRAY_SIZE(m25p_ids) - 1) { > -> Better: "if (info == NULL) ..." You've got all the pointers +> Better: "if (info = NULL) ..." You've got all the pointers > in hand; don't use indices. [...] > > + if (id != &m25p_ids[i]) { @@ -65,3 +65,8 @@ CAT25 chips. Yep, good ideas. Though, the code will vanish anyway. Patches on the way... + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 7d7cb70..bc3dd95 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,19 +2,19 @@ "ref\020090731004100.GB8371@oksana.dev.rtsoft.ru\0" "ref\0200908031954.50955.david-b@pacbell.net\0" "From\0Anton Vorontsov <avorontsov@ru.mvista.com>\0" - "Subject\0Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching\0" - "Date\0Wed, 19 Aug 2009 01:44:49 +0400\0" + "Subject\0Re: [lm-sensors] [PATCH 2/6] mtd: m25p80: Convert to device table\0" + "Date\0Tue, 18 Aug 2009 21:44:49 +0000\0" "To\0David Brownell <david-b@pacbell.net>\0" - "Cc\0Ben Dooks <ben@fluff.org>" + "Cc\0Andrew Morton <akpm@linux-foundation.org>" + Ben Dooks <ben@fluff.org> + David Woodhouse <dwmw2@infradead.org> + Grant Likely <grant.likely@secretlab.ca> Benjamin Herrenschmidt <benh@kernel.crashing.org> + Jean Delvare <khali@linux-fr.org> + linux-mtd@lists.infradead.org linux-kernel@vger.kernel.org lm-sensors@lm-sensors.org - Grant Likely <grant.likely@secretlab.ca> - linuxppc-dev@ozlabs.org - linux-mtd@lists.infradead.org - Jean Delvare <khali@linux-fr.org> - Andrew Morton <akpm@linux-foundation.org> - " David Woodhouse <dwmw2@infradead.org>\0" + " linuxppc-dev@ozlabs.org\0" "\00:1\0" "b\0" "Hi David,\n" @@ -51,7 +51,7 @@ "\n" "M25Px0 chips can be JEDEC and non-JEDEC, e.g. Nymonyx manufacturing\n" "\"M25P80\" chips in two variants: \"The RDID instruction is available only\n" - "for parts made with Technology T9HX (0.11\316\274m), ...\"\n" + "for parts made with Technology T9HX (0.11\303\216\302\274m), ...\"\n" "\n" "Most (but not all) non-JEDEC EEPROMs will return \"0\" for RDID opcode\n" "though (in that case warning is misleading). And for the chips that\n" @@ -72,9 +72,9 @@ "> There's a new error case of course: new-style but data->type\n" "> doesn't match id->name.\n" "[...]\n" - "> > +\t\tif (i == ARRAY_SIZE(m25p_ids) - 1) {\n" + "> > +\t\tif (i = ARRAY_SIZE(m25p_ids) - 1) {\n" "> \n" - "> Better: \"if (info == NULL) ...\" You've got all the pointers\n" + "> Better: \"if (info = NULL) ...\" You've got all the pointers\n" "> in hand; don't use indices.\n" "[...]\n" "> > +\t\t\tif (id != &m25p_ids[i]) {\n" @@ -83,6 +83,11 @@ "\n" "Yep, good ideas. Though, the code will vanish anyway.\n" "\n" - Patches on the way... + "Patches on the way...\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -0f05bca393dcda38f3cbc9bc34dcd112b087e8283a176845125dd362656ac8a9 +4017f11c3ee0cf995226b8a2974a3a5b98eacaec42b23e3c3137616febe61a9b
diff --git a/a/content_digest b/N2/content_digest index 7d7cb70..9a00283 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -6,10 +6,8 @@ "Date\0Wed, 19 Aug 2009 01:44:49 +0400\0" "To\0David Brownell <david-b@pacbell.net>\0" "Cc\0Ben Dooks <ben@fluff.org>" - Benjamin Herrenschmidt <benh@kernel.crashing.org> linux-kernel@vger.kernel.org lm-sensors@lm-sensors.org - Grant Likely <grant.likely@secretlab.ca> linuxppc-dev@ozlabs.org linux-mtd@lists.infradead.org Jean Delvare <khali@linux-fr.org> @@ -85,4 +83,4 @@ "\n" Patches on the way... -0f05bca393dcda38f3cbc9bc34dcd112b087e8283a176845125dd362656ac8a9 +aa04d5a7bf4c279e33f9680678b64f9892a1bf8f8e8f80d6fd11129c3d09f7d5
diff --git a/a/content_digest b/N3/content_digest index 7d7cb70..f5a6d97 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -5,16 +5,16 @@ "Subject\0Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching\0" "Date\0Wed, 19 Aug 2009 01:44:49 +0400\0" "To\0David Brownell <david-b@pacbell.net>\0" - "Cc\0Ben Dooks <ben@fluff.org>" + "Cc\0Andrew Morton <akpm@linux-foundation.org>" + Ben Dooks <ben@fluff.org> + David Woodhouse <dwmw2@infradead.org> + Grant Likely <grant.likely@secretlab.ca> Benjamin Herrenschmidt <benh@kernel.crashing.org> + Jean Delvare <khali@linux-fr.org> + linux-mtd@lists.infradead.org linux-kernel@vger.kernel.org lm-sensors@lm-sensors.org - Grant Likely <grant.likely@secretlab.ca> - linuxppc-dev@ozlabs.org - linux-mtd@lists.infradead.org - Jean Delvare <khali@linux-fr.org> - Andrew Morton <akpm@linux-foundation.org> - " David Woodhouse <dwmw2@infradead.org>\0" + " linuxppc-dev@ozlabs.org\0" "\00:1\0" "b\0" "Hi David,\n" @@ -85,4 +85,4 @@ "\n" Patches on the way... -0f05bca393dcda38f3cbc9bc34dcd112b087e8283a176845125dd362656ac8a9 +3410b99ba5b53438a09d192e4c7791c29e9302aa2b45d775309202834a07e3c4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.