All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Hannes Reinecke <hare@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	stable@kernel.org
Subject: Re: [REGRESSION] _end symbol missing from Symbol.map
Date: Wed, 19 Aug 2009 09:37:04 -0700	[thread overview]
Message-ID: <20090819093704.f1620baa.akpm@linux-foundation.org> (raw)
In-Reply-To: <4A83B680.5000508@suse.de>

On Thu, 13 Aug 2009 08:45:20 +0200 Hannes Reinecke <hare@suse.de> wrote:

> Hi all,
> 
> with 2.6.31 'crash' on x86_64 falls flat on its face as the '_end' symbol
> is missing from the System.map file.
> 
> The culprit is commit 091e52c3551d3031343df24b573b770b4c6c72b6,
> which moved the '_end' symbol into it's own section.
> Apparently this causes kallsyms to not reference it properly.
> 
> So either we'd need to revert part of the patch to not
> include _end in it's own section:
> 
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index 59f31d2..1422df5 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -376,9 +376,7 @@ SECTIONS
>                 __brk_limit = .;
>         }
>  
> -       .end : AT(ADDR(.end) - LOAD_OFFSET) {
> -               _end = .;
> -       }
> +       _end = .;
>  
>         /* Sections to be discarded */
>         /DISCARD/ : {
> 
> or someone has to fixup kallsyms. But this is far beyond my comfort zone.
> 

So System.map is part of the kernel API too?  Sigh.

Your email client replaces tabs with spaces.

The patch didn't have a signed-off-by:

I queued it up, and tagged it for -stable backporting.  Unless we come
up with something better.

We might not get this into 2.6.31, in which case this fix or its
replacement will need backporting to 2.6.30.x and 2.6.31.x (IMO).


  reply	other threads:[~2009-08-19 16:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-13  6:45 [REGRESSION] _end symbol missing from Symbol.map Hannes Reinecke
2009-08-19 16:37 ` Andrew Morton [this message]
2009-08-20  5:59   ` Hannes Reinecke
2009-08-20 10:59     ` Takashi Iwai
2009-08-20 19:15       ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090819093704.f1620baa.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=hare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.