From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux acpi <linux-acpi@vger.kernel.org>,
linux-pm <linux-pm@lists.osdl.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 5/5] acpi-based wakeup event detection
Date: Wed, 19 Aug 2009 12:42:20 +0100 [thread overview]
Message-ID: <20090819114220.GA12216@srcf.ucam.org> (raw)
In-Reply-To: <1250666661.23178.120.camel@sli10-desk.sh.intel.com>
On Wed, Aug 19, 2009 at 03:24:21PM +0800, Shaohua Li wrote:
> + ret = acpi_gpe_pme_check(dev);
> +
> + acpi_disable_gpe(dev->wakeup.gpe_device, dev->wakeup.gpe_number);
I don't think we want to unconditionally disable the GPE.
> +
> + acpi_init_gpe_pme();
I'm also not keen on haing the notifier being at the ACPI level. Are we
guaranteed that the GPE will only be used for wakeups, and will never
trigger any other sort of notification? Keeping this at the bus level
may be more practical.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2009-08-19 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 7:24 [PATCH 5/5] acpi-based wakeup event detection Shaohua Li
2009-08-19 11:42 ` Matthew Garrett [this message]
2009-08-20 3:16 ` Shaohua Li
2009-08-20 20:03 ` Rafael J. Wysocki
2009-08-20 20:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819114220.GA12216@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=rjw@sisk.pl \
--cc=shaohua.li@intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.