From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/3] Add SuperH FSI driver support for ALSA Date: Wed, 19 Aug 2009 13:42:07 +0100 Message-ID: <20090819124206.GA20838@rakim.wolfsonmicro.main> References: <20090819122801.GC20227@rakim.wolfsonmicro.main> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 3499F243F1 for ; Wed, 19 Aug 2009 14:42:08 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: Kuninori Morimoto , alsa-devel@alsa-project.org, lethal@linux-sh.org, Magnus Damm , linux-sh@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, Aug 19, 2009 at 02:39:06PM +0200, Takashi Iwai wrote: > Note that it's snd_pcm_lib_malloc_pages(), not the kernel's standard > one like alloc_pages(). The former frees the old buffer by itself > when resized, so you don't need to call snd_pcm_lib_free_pages() > (as long as it's called in hw_free callback). Oh, so it does - I misread the code as only shrinking an existing buffer. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Date: Wed, 19 Aug 2009 12:42:07 +0000 Subject: Re: [PATCH 1/3] Add SuperH FSI driver support for ALSA Message-Id: <20090819124206.GA20838@rakim.wolfsonmicro.main> List-Id: References: <20090819122801.GC20227@rakim.wolfsonmicro.main> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Takashi Iwai Cc: Kuninori Morimoto , alsa-devel@alsa-project.org, lethal@linux-sh.org, Magnus Damm , linux-sh@vger.kernel.org On Wed, Aug 19, 2009 at 02:39:06PM +0200, Takashi Iwai wrote: > Note that it's snd_pcm_lib_malloc_pages(), not the kernel's standard > one like alloc_pages(). The former frees the old buffer by itself > when resized, so you don't need to call snd_pcm_lib_free_pages() > (as long as it's called in hw_free callback). Oh, so it does - I misread the code as only shrinking an existing buffer.