diff for duplicates of <20090819132420.GA6137@localhost> diff --git a/a/1.txt b/N1/1.txt index 83474d3..901712f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,7 +14,7 @@ On Wed, Aug 19, 2009 at 08:25:56PM +0800, Minchan Kim wrote: > >> >> > >> >> Currently, mlock() systemcall doesn't gurantee to mark the page PG_Mlocked > >> > -> >> > mark PG_mlocked +> >> > A A A A A A A A A A A A A A A A A A A A A A A A A A mark PG_mlocked > >> > > >> >> because some race prevent page grabbing. > >> >> In that case, instead vmscan move the page to unevictable lru. @@ -26,7 +26,7 @@ On Wed, Aug 19, 2009 at 08:25:56PM +0800, Minchan Kim wrote: > >> >> > >> >> Plus, vmscan should mark PG_Mlocked when cull mlocked page. > >> > -> >> > PG_mlocked +> >> > A A A A A A A A A A A A A PG_mlocked > >> > > >> >> Otherwise vm stastics show strange number. > >> >> @@ -40,17 +40,17 @@ On Wed, Aug 19, 2009 at 08:25:56PM +0800, Minchan Kim wrote: > >> > >> >> Index: b/mm/rmap.c > >> >> =================================================================== -> >> >> --- a/mm/rmap.c 2009-08-18 19:48:14.000000000 +0900 -> >> >> +++ b/mm/rmap.c 2009-08-18 23:47:34.000000000 +0900 +> >> >> --- a/mm/rmap.c A A A 2009-08-18 19:48:14.000000000 +0900 +> >> >> +++ b/mm/rmap.c A A A 2009-08-18 23:47:34.000000000 +0900 > >> >> @@ -362,7 +362,9 @@ static int page_referenced_one(struct pa -> >> >> * unevictable list. -> >> >> */ -> >> >> if (vma->vm_flags & VM_LOCKED) { -> >> >> - *mapcount = 1; /* break early from loop */ -> >> >> + *mapcount = 1; /* break early from loop */ -> >> >> + *vm_flags |= VM_LOCKED; /* for prevent to move active list */ +> >> >> A A A A * unevictable list. +> >> >> A A A A */ +> >> >> A A A if (vma->vm_flags & VM_LOCKED) { +> >> >> - A A A A A A *mapcount = 1; A /* break early from loop */ +> >> >> + A A A A A A *mapcount = 1; A A A A A /* break early from loop */ +> >> >> + A A A A A A *vm_flags |= VM_LOCKED; /* for prevent to move active list */ > >> > -> >> >> + try_set_page_mlocked(vma, page); +> >> >> + A A A A A A try_set_page_mlocked(vma, page); > >> > > >> > That call is not absolutely necessary? > >> @@ -88,3 +88,9 @@ which looks more intuitive and less confusing. Thanks, Fengguang + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 15138ca..8413049 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -42,7 +42,7 @@ "> >> >>\n" "> >> >> Currently, mlock() systemcall doesn't gurantee to mark the page PG_Mlocked\n" "> >> >\n" - "> >> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240mark PG_mlocked\n" + "> >> > A A A A A A A A A A A A A A A A A A A A A A A A A A mark PG_mlocked\n" "> >> >\n" "> >> >> because some race prevent page grabbing.\n" "> >> >> In that case, instead vmscan move the page to unevictable lru.\n" @@ -54,7 +54,7 @@ "> >> >>\n" "> >> >> Plus, vmscan should mark PG_Mlocked when cull mlocked page.\n" "> >> >\n" - "> >> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 PG_mlocked\n" + "> >> > A A A A A A A A A A A A A PG_mlocked\n" "> >> >\n" "> >> >> Otherwise vm stastics show strange number.\n" "> >> >>\n" @@ -68,17 +68,17 @@ "> >>\n" "> >> >> Index: b/mm/rmap.c\n" "> >> >> ===================================================================\n" - "> >> >> --- a/mm/rmap.c \302\240 \302\240 \302\240 2009-08-18 19:48:14.000000000 +0900\n" - "> >> >> +++ b/mm/rmap.c \302\240 \302\240 \302\240 2009-08-18 23:47:34.000000000 +0900\n" + "> >> >> --- a/mm/rmap.c A A A 2009-08-18 19:48:14.000000000 +0900\n" + "> >> >> +++ b/mm/rmap.c A A A 2009-08-18 23:47:34.000000000 +0900\n" "> >> >> @@ -362,7 +362,9 @@ static int page_referenced_one(struct pa\n" - "> >> >> \302\240 \302\240 \302\240 \302\240* unevictable list.\n" - "> >> >> \302\240 \302\240 \302\240 \302\240*/\n" - "> >> >> \302\240 \302\240 \302\240 if (vma->vm_flags & VM_LOCKED) {\n" - "> >> >> - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 *mapcount = 1; \302\240/* break early from loop */\n" - "> >> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 *mapcount = 1; \302\240 \302\240 \302\240 \302\240 \302\240/* break early from loop */\n" - "> >> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 *vm_flags |= VM_LOCKED; /* for prevent to move active list */\n" + "> >> >> A A A A * unevictable list.\n" + "> >> >> A A A A */\n" + "> >> >> A A A if (vma->vm_flags & VM_LOCKED) {\n" + "> >> >> - A A A A A A *mapcount = 1; A /* break early from loop */\n" + "> >> >> + A A A A A A *mapcount = 1; A A A A A /* break early from loop */\n" + "> >> >> + A A A A A A *vm_flags |= VM_LOCKED; /* for prevent to move active list */\n" "> >> >\n" - "> >> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 try_set_page_mlocked(vma, page);\n" + "> >> >> + A A A A A A try_set_page_mlocked(vma, page);\n" "> >> >\n" "> >> > That call is not absolutely necessary?\n" "> >>\n" @@ -115,6 +115,12 @@ "which looks more intuitive and less confusing.\n" "\n" "Thanks,\n" - Fengguang + "Fengguang\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -31e77680be6d59e57c6b4a79683031287faaa89f508b9299284e752de916988b +77baf3e46d58a90e2816c48bf14cdc8b65860851894b112fafaf4ce59e603d9d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.