From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mdmp6-0005dQ-N4 for mharc-grub-devel@gnu.org; Wed, 19 Aug 2009 11:11:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mdmp3-0005cY-Vs for grub-devel@gnu.org; Wed, 19 Aug 2009 11:11:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mdmoz-0005ZV-6x for grub-devel@gnu.org; Wed, 19 Aug 2009 11:11:33 -0400 Received: from [199.232.76.173] (port=50606 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mdmoy-0005Ye-JC for grub-devel@gnu.org; Wed, 19 Aug 2009 11:11:29 -0400 Received: from mx20.gnu.org ([199.232.41.8]:53444) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mdmow-0001bm-0K for grub-devel@gnu.org; Wed, 19 Aug 2009 11:11:26 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8] helo=aybabtu.com) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mdmou-0000Wk-Va for grub-devel@gnu.org; Wed, 19 Aug 2009 11:11:25 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mdmou-0007SN-9K for grub-devel@gnu.org; Wed, 19 Aug 2009 17:11:24 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mdmot-000245-C3 for grub-devel@gnu.org; Wed, 19 Aug 2009 17:11:23 +0200 Date: Wed, 19 Aug 2009 17:11:23 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090819151123.GB7859@thorin> References: <20090817134302.GI32551@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] save around 100 bytes on core.img by inlining small misc.c functions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2009 15:11:34 -0000 On Mon, Aug 17, 2009 at 03:54:06PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 17, 2009 at 3:43 PM, Robert Millan wrote: > > On Sat, Aug 15, 2009 at 04:47:32PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> +static inline char * > >> +grub_strncat (char *dest, const char *src, int c) > >> +{ > >> +  char *p = dest; > >> + > >> +  while (*p) > >> +    p++; > >> + > >> +  while ((*p = *src) != '\0' && c--) > >> +    { > >> +      p++; > >> +      src++; > >> +    } > >> + > >> +  *p = '\0'; > >> + > >> +  return dest; > >> +} > > > > Some of them (like this one) are surprisingly big.  Did you test them > > separately? > Yes I did. My test environment was a core.img with pc+fat+biosdisk. I > have a log which functions save how much. In this case inlining > strncat saved 21 bytes. The reason for some bigger functions to be > inlined is that they are used only in non-size critical parts. In this > case it's used in LUA and iso9660.mod (one call). So inlining strncat > always saves space (even if iso9660.mod is in core.img but there is no > size limit when booting from cd). Ok, fine with me then. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."