From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mdn0r-0001La-Ux for mharc-grub-devel@gnu.org; Wed, 19 Aug 2009 11:23:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mdn0q-0001L2-Aw for grub-devel@gnu.org; Wed, 19 Aug 2009 11:23:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mdn0l-0001IA-Bv for grub-devel@gnu.org; Wed, 19 Aug 2009 11:23:43 -0400 Received: from [199.232.76.173] (port=35821 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mdn0l-0001I5-7r for grub-devel@gnu.org; Wed, 19 Aug 2009 11:23:39 -0400 Received: from mx20.gnu.org ([199.232.41.8]:53984) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mdn0k-00056L-Nt for grub-devel@gnu.org; Wed, 19 Aug 2009 11:23:38 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8] helo=aybabtu.com) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mdn0k-00018v-5x for grub-devel@gnu.org; Wed, 19 Aug 2009 11:23:38 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mdn0j-0007TJ-83 for grub-devel@gnu.org; Wed, 19 Aug 2009 17:23:37 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mdn0i-00026g-M2 for grub-devel@gnu.org; Wed, 19 Aug 2009 17:23:36 +0200 Date: Wed, 19 Aug 2009 17:23:36 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090819152336.GE7859@thorin> References: <20090817134639.GJ32551@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-Detected-Operating-System: by mx20.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [GITGRUB] FB driver for EFI X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2009 15:23:44 -0000 On Wed, Aug 19, 2009 at 02:25:08AM +0800, Bean wrote: > > Have you tried linux_video_setup as present in i386/linux.c in > > i386/efi/linux.c ? It would be nice if we could share more code > > between these 2 files. If it works and you judge that  i386/linux.c > > and i386/efi/linux.c are similar enough you can merge them using > > ifdef's when needed > > It should be ok to merge i386/efi/linux.c with i386/linux.c now that > the fb detection code is separated. Yes, I think both files should merge. But please do it separately from this patch. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."