From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 4/8] Use vmalloc for large cgroups pidlist allocations Date: Thu, 20 Aug 2009 14:14:00 -0700 Message-ID: <20090820141400.f6d3d5a6.akpm@linux-foundation.org> References: <20090818235059.22531.42618.stgit@menage.mtv.corp.google.com> <20090818235827.22531.60306.stgit@menage.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090818235827.22531.60306.stgit-u3IScbYxn0zHt/MElyovVYaSKrA+ACpX0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Menage Cc: bblum-OM76b2Iv3yLQjUSlxSEPGw@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Dave Hansen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, David Rientjes List-Id: containers.vger.kernel.org On Tue, 18 Aug 2009 16:58:27 -0700 Paul Menage wrote: > From: Ben Blum > > > Use vmalloc for large cgroups pidlist allocations > > Separates all pidlist allocation requests to a separate function that judges > based on the requested size whether or not the array needs to be vmalloced or > can be gotten via kmalloc, and similar for kfree/vfree. > Hang on. Isn't this why Dave just wrote and I just rush-merged lib/flex_array.c? Was that code evaluated for this application and judged unsuitable? If so, for what reason? If not, can someone please do this? Ta. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755449AbZHTVT5 (ORCPT ); Thu, 20 Aug 2009 17:19:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754926AbZHTVT4 (ORCPT ); Thu, 20 Aug 2009 17:19:56 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:40858 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbZHTVTz (ORCPT ); Thu, 20 Aug 2009 17:19:55 -0400 Date: Thu, 20 Aug 2009 14:14:00 -0700 From: Andrew Morton To: Paul Menage Cc: bblum@andrew.cmu.edu, lizf@cn.fujitsu.com, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, Dave Hansen , David Rientjes Subject: Re: [PATCH 4/8] Use vmalloc for large cgroups pidlist allocations Message-Id: <20090820141400.f6d3d5a6.akpm@linux-foundation.org> In-Reply-To: <20090818235827.22531.60306.stgit@menage.mtv.corp.google.com> References: <20090818235059.22531.42618.stgit@menage.mtv.corp.google.com> <20090818235827.22531.60306.stgit@menage.mtv.corp.google.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Aug 2009 16:58:27 -0700 Paul Menage wrote: > From: Ben Blum > > > Use vmalloc for large cgroups pidlist allocations > > Separates all pidlist allocation requests to a separate function that judges > based on the requested size whether or not the array needs to be vmalloced or > can be gotten via kmalloc, and similar for kfree/vfree. > Hang on. Isn't this why Dave just wrote and I just rush-merged lib/flex_array.c? Was that code evaluated for this application and judged unsuitable? If so, for what reason? If not, can someone please do this? Ta.