From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] Include in balloon page tracking only PFNs which are marked as RAM in E820. Date: Thu, 20 Aug 2009 12:43:08 -0400 Message-ID: <20090820164308.GB28012@phenom.dumpdata.com> References: <1250709149-4730-1-git-send-email-konrad.wilk@oracle.com> <1250709149-4730-2-git-send-email-konrad.wilk@oracle.com> <20090819191607.GA4798@phenom.dumpdata.com> <19085.29617.299035.903514@gianluca.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <19085.29617.299035.903514@gianluca.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Gianluca Guida Cc: Gianluca Guida , "xen-devel@lists.xensource.com" , Konrad Rzeszutek Wilk List-Id: xen-devel@lists.xenproject.org On Thu, Aug 20, 2009 at 05:02:57PM +0100, Gianluca Guida wrote: > Hi, > > Ok, by looking at this patch it's clear that you are testing with a > kernel that tries to allow kernels to boot ballooned. > > In this case the patch is correct. Since the patch is actually > reverted, I think we should wait to apply it until I succeed to > reproduce the bug that caused Jeremy to revert it. You are talking about the 7394b25905929a92e51771b832ee67b70ccebcf0 patch? I will wait and if this patch is still needed I will send it out to LKML/xen-devel with your style comment. > > > + int is_ram = page_is_ram(pfn); > > Do you really need to declare this as a variable? couldn't you put the Not at all. Right after I sent it out I realized it would have been looking better without. > expression in the if statement?