From: Andrew Morton <akpm@linux-foundation.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, jeff@garzik.org,
benh@kernel.crashing.org, htejun@gmail.com, bzolnier@gmail.com,
alan@lxorguk.ukuu.org.uk, jens.axboe@oracle.com
Subject: Re: [PATCH 1/4] direct-io: unify argument passing by adding a dio_args structure
Date: Thu, 20 Aug 2009 17:03:06 -0700 [thread overview]
Message-ID: <20090820170306.93388637.akpm@linux-foundation.org> (raw)
In-Reply-To: <1250763466-24282-2-git-send-email-jens.axboe@oracle.com>
On Thu, 20 Aug 2009 12:17:36 +0200
Jens Axboe <jens.axboe@oracle.com> wrote:
> The O_DIRECT IO path is a mess of arguments. Clean that up by passing
> those arguments in a dedicated dio_args structure.
>
> This is in preparation for changing the internal implementation to be
> page based instead of using iovecs.
>
> ...
>
> +/*
> + * Arguments passwed to aops->direct_IO()
cnat tpye
> + */
> +struct dio_args {
> + int rw;
> + const struct iovec *iov;
> + unsigned long length;
> + loff_t offset;
> + unsigned long nr_segs;
> +};
It would be nice to have some documentation. Especially for that
pestiferous `rw' thing.
nr_segs is associated with the iovec and might as well be contiguous
with it in the struct.
next prev parent reply other threads:[~2009-08-21 0:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 10:17 [PATCH 0/6] Lazy workqueues Jens Axboe
2009-08-20 10:17 ` [PATCH 1/4] direct-io: unify argument passing by adding a dio_args structure Jens Axboe
2009-08-20 10:17 ` [PATCH 1/6] workqueue: replace singlethread/freezable/rt parameters and variables with flags Jens Axboe
2009-08-20 10:17 ` [PATCH 2/4] direct-io: make O_DIRECT IO path be page based Jens Axboe
2009-08-20 10:17 ` [PATCH 2/6] workqueue: add support for lazy workqueues Jens Axboe
2009-08-20 10:17 ` [PATCH 3/6] crypto: use " Jens Axboe
2009-08-20 10:17 ` [PATCH 3/4] direct-io: add a "IO for kernel" flag to kiocb Jens Axboe
2009-08-20 10:17 ` [PATCH 4/6] libata: use lazy workqueues for the pio task Jens Axboe
2009-08-20 10:17 ` [PATCH 4/5] loop: support O_DIRECT transfer mode Jens Axboe
2009-08-20 10:17 ` [PATCH 5/6] aio: use lazy workqueues Jens Axboe
2009-08-20 10:17 ` [PATCH 4/4] direct-io: get rid of irq flag saving where it isn't needed Jens Axboe
2009-08-20 10:17 ` [PATCH 6/6] sunrpc: use lazy workqueues Jens Axboe
2009-08-21 0:20 ` [PATCH 2/6] workqueue: add support for " Andrew Morton
2009-08-24 8:06 ` Jens Axboe
2009-08-20 13:19 ` [PATCH 2/4] direct-io: make O_DIRECT IO path be page based Trond Myklebust
2009-08-24 7:58 ` Jens Axboe
2009-08-21 0:12 ` Andrew Morton
2009-08-24 8:00 ` Jens Axboe
2009-08-21 0:03 ` Andrew Morton [this message]
2009-08-24 7:58 ` [PATCH 1/4] direct-io: unify argument passing by adding a dio_args structure Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2009-08-18 8:34 [PATCH 0/4] Page based O_DIRECT v2 Jens Axboe
2009-08-18 8:34 ` [PATCH 1/4] direct-io: unify argument passing by adding a dio_args structure Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820170306.93388637.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=bzolnier@gmail.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.