From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: pvops dom0 work roadmap
Date: Thu, 20 Aug 2009 13:11:51 -0400
Message-ID: <20090820171151.GA28810@phenom.dumpdata.com>
References: <4A8AF65A.2040904@goop.org>
	<20090818200718.GD19938@edu.joroinen.fi> <4A8B0B1A.80406@goop.org>
	<20090819132609.GA21730@phenom.dumpdata.com>
	<4A8C338C.4010700@goop.org>
	<20090819174520.GA30788@phenom.dumpdata.com>
	<19085.28788.510136.852423@gianluca.uk.xensource.com>
	<20090820163948.GA28012@phenom.dumpdata.com>
	<19085.31601.839257.132735@gianluca.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <19085.31601.839257.132735@gianluca.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Gianluca Guida <gianluca.guida@citrix.com>
Cc: Gianluca Guida <Gianluca.Guida@eu.citrix.com>, Xen-devel <xen-devel@lists.xensource.com>, Jeremy Fitzhardinge <jeremy@goop.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, Aug 20, 2009 at 05:36:01PM +0100, Gianluca Guida wrote:
> Konrad Rzeszutek Wilk writes:
>  > On Thu, Aug 20, 2009 at 04:49:08PM +0100, Gianluca Guida wrote:
>  > > Konrad Rzeszutek Wilk writes:
>  > >  > I will retry this, but in the meantime I am tracking balloon accessing non-existent pages:
>  > > 
>  > > Hm, what tree of dom0 kernel are you using? Is commit
>  > 
>  > [konrad@phenom linux]$ git checkout origin/rebase/master -b boo
>  > Branch boo set up to track remote branch refs/remotes/origin/rebase/master.
>  > Switched to a new branch 'boo'
>  > [konrad@phenom linux]$ git show  7394b25905929a92e51771b832ee67b70ccebcf0
>  > fatal: bad object 7394b25905929a92e51771b832ee67b70ccebcf0
> 
> Ok, you don't have the revert, do you have
> a472909fe0e3b7bfa34f7c9dd748121b0ede0ee6 in your tree?

Yes.

> 
>  > 
>  > > 7394b25905929a92e51771b832ee67b70ccebcf0 (Revert "Xen: Allow guest to
>  > > boot ballooned.") there?
>  > 
>  > What branch is it in?
> 
> rebase/master, checked in last week.

Hmmm. Let me checkout a new tree and see why I am behind.

> 
>  > 
>  > > 
>  > > The point is that xen_memory_setup should truncate the ram visible in
>  > > the e820 map to xen_start_info->nr_pages, so that the balloon driver
>  > > would never try to add pages on boot.
>  > 
>  > Sure. This problem is for pages above ->nr_pages.
> 
> max_pfn is calculated by the e820 map, so there would be nothing above
> nr_pages.

Duh! Yes

> 
> I was assuming you had an up-to-date tree, where there's no "Allow
> guest to boot ballooned" patch. When that patch is present no
> truncation happens, and you get hit by that bug, which your patch
> fixes.
> 
> Cheers,
> Gianluca