From: Michal Schmidt <mschmidt@redhat.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Mark McLoughlin <markmc@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] xenfb: connect to backend before registering fb
Date: Fri, 21 Aug 2009 15:44:07 +0200 [thread overview]
Message-ID: <20090821154407.6337421b@leela> (raw)
In-Reply-To: <20090821151352.1676de18@leela>
As soon as the framebuffer is registered, our methods may be called by the
kernel. This leads to a crash as xenfb_refresh() gets called before we have
the irq.
Connect to the backend before registering our framebuffer with the kernel.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
--
Index: linux-git/drivers/video/xen-fbfront.c
===================================================================
--- linux-git.orig/drivers/video/xen-fbfront.c
+++ linux-git/drivers/video/xen-fbfront.c
@@ -454,6 +454,10 @@ static int __devinit xenfb_probe(struct
xenfb_init_shared_page(info, fb_info);
+ ret = xenfb_connect_backend(dev, info);
+ if (ret < 0)
+ goto error;
+
ret = register_framebuffer(fb_info);
if (ret) {
fb_deferred_io_cleanup(fb_info);
@@ -464,10 +468,6 @@ static int __devinit xenfb_probe(struct
}
info->fb_info = fb_info;
- ret = xenfb_connect_backend(dev, info);
- if (ret < 0)
- goto error;
-
xenfb_make_preferred_console();
return 0;
next prev parent reply other threads:[~2009-08-21 13:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 10:40 DomU crashes during xenfb initialization Michal Schmidt
2009-08-21 13:09 ` Michal Schmidt
2009-08-21 13:13 ` Michal Schmidt
2009-08-21 13:44 ` Michal Schmidt [this message]
2009-08-21 22:45 ` [PATCH] xenfb: connect to backend before registering fb Jeremy Fitzhardinge
2009-08-23 19:32 ` Michal Schmidt
2009-08-21 23:57 ` DomU crashes during xenfb initialization Morten P.D. Stevens
-- strict thread matches above, loose matches on Subject: below --
2009-08-27 19:22 [PATCH] xenfb: connect to backend before registering fb Jeremy Fitzhardinge
2009-08-27 19:22 ` Jeremy Fitzhardinge
2009-08-28 9:12 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090821154407.6337421b@leela \
--to=mschmidt@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.