All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Rientjes <rientjes@google.com>
Cc: dave@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
	Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [patch 4/4 -mm] flex_array: add flex_array_shrink function
Date: Fri, 21 Aug 2009 16:49:35 -0700	[thread overview]
Message-ID: <20090821164935.173689a0.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.2.00.0908211621160.28611@chino.kir.corp.google.com>

On Fri, 21 Aug 2009 16:21:49 -0700 (PDT)
David Rientjes <rientjes@google.com> wrote:

> +/**
> + * flex_array_shrink - free unused second-level pages
> + *
> + * Frees all second-level pages that consist solely of unused
> + * elements.  Returns the number of pages freed.
> + *
> + * Locking must be provided by the caller.
> + */
> +int flex_array_shrink(struct flex_array *fa)

It's logical but afaik unconventional that none of the flex_array
kerneldoc actually documents the `struct flex_array *fa' argument.


We're all waiting with bated breath to see who will be the first to use
flex_array in live code.

Sometime we'll need to move flex_array.o from lib-y to obj-y and fill
it up with EXPORT_SYMBOL()s.  2.6.32 I expect.


  reply	other threads:[~2009-08-21 23:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-21 23:21 [patch 1/4 -mm] flex_array: convert element_nr formals to unsigned David Rientjes
2009-08-21 23:21 ` [patch 2/4 -mm] flex_array: add flex_array_clear function David Rientjes
2009-08-24 15:41   ` Dave Hansen
2009-08-24 20:29     ` David Rientjes
2009-08-24 20:38       ` Dave Hansen
2009-08-24 20:50         ` David Rientjes
2009-08-24 21:28           ` Dave Hansen
2009-08-24 22:32             ` David Rientjes
2009-08-21 23:21 ` [patch 3/4 -mm] flex_array: poison free elements David Rientjes
2009-08-24 15:56   ` Dave Hansen
2009-08-24 20:41     ` David Rientjes
2009-08-24 21:16       ` Dave Hansen
2009-08-24 22:40         ` David Rientjes
2009-08-24 21:42       ` Dave Hansen
2009-08-24 22:44         ` David Rientjes
2009-09-08 22:26           ` David Rientjes
2009-09-09  2:05             ` Li Zefan
2009-09-09  3:18               ` David Rientjes
2009-09-09  3:31                 ` Li Zefan
2009-09-09  3:41                   ` David Rientjes
2009-09-09  3:45                     ` Li Zefan
2009-09-09  4:15                       ` David Rientjes
2009-09-09 15:28             ` Dave Hansen
2009-09-09 19:18               ` David Rientjes
2009-09-09 19:22                 ` Dave Hansen
2009-09-09 19:34                   ` David Rientjes
2009-08-21 23:21 ` [patch 4/4 -mm] flex_array: add flex_array_shrink function David Rientjes
2009-08-21 23:49   ` Andrew Morton [this message]
2009-08-22  0:02     ` Randy Dunlap
2009-08-22 21:28     ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090821164935.173689a0.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=dave@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.