From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [RFC][PATCH 2/3] PM: Asynchronous suspend of devices Date: Sat, 22 Aug 2009 11:25:54 +0200 Message-ID: <20090822092554.GD11448@elf.ucw.cz> References: <200908122218.13975.rjw@sisk.pl> <200908122221.20568.rjw@sisk.pl> <20090814163509.GK1626@ucw.cz> <200908152304.59881.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:43299 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932086AbZHVJ0A (ORCPT ); Sat, 22 Aug 2009 05:26:00 -0400 Content-Disposition: inline In-Reply-To: <200908152304.59881.rjw@sisk.pl> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Rafael J. Wysocki" Cc: linux-pm , linux-acpi , Linux Kernel Mailing List , Zhang Rui , Len Brown , Alan Stern , Arjan van de Ven > > > + * The driver of the device won't receive interrupts while this function is > > > + * being executed. > > > */ > > > @@ -696,13 +746,19 @@ int dpm_suspend_noirq(pm_message_t state > > > suspend_device_irqs(); > > > mutex_lock(&dpm_list_mtx); > > > list_for_each_entry_reverse(dev, &dpm_list, power.entry) { > > > + dev->power.status = DPM_OFF_IRQ; > > > error = device_suspend_noirq(dev, state); > > > if (error) { > > > pm_dev_err(dev, state, " late", error); > > > + dev->power.status = DPM_OFF; > > > + break; > > > + } > > > + if (async_error) { > > > + error = async_error; > > > break; > > > > async_error is 'interesting'. How does locking work in noirq case? > > It's racy, a little bit. :-) > > If two async drivers return errors exactly at the same time, one of them will > win the race, but it doesn't really matter which one wins as long as > async_error is different from zero as a result. And it will be, since it's > an 'int' and the integrity of these is guaranteed. Rather than relying on atomicity of 'int' (where half of kernel hackers says it is and second half says it is not), can we just use atomic_t? It compiles to same code on sane architectures, and serves as documentation/warning... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html