From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: Reversed order of labels?
Date: Sat, 22 Aug 2009 20:32:43 +0000 [thread overview]
Message-ID: <20090822223243.0a667bd0@skybase> (raw)
In-Reply-To: <4A9006A1.7010706@gmail.com>
On Sat, 22 Aug 2009 16:54:25 +0200
Roel Kluin <roel.kluin@gmail.com> wrote:
> Fix the order of goto labels.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Is this correct? Please review.
>
> diff --git a/drivers/s390/char/tape_core.c b/drivers/s390/char/tape_core.c
> index 1d420d9..7424d64 100644
> --- a/drivers/s390/char/tape_core.c
> +++ b/drivers/s390/char/tape_core.c
> @@ -358,11 +358,11 @@ tape_generic_online(struct tape_device *device,
>
> out_char:
> tapechar_cleanup_device(device);
> +out_minor:
> + tape_remove_minor(device);
> out_discipline:
> device->discipline->cleanup_device(device);
> device->discipline = NULL;
> -out_minor:
> - tape_remove_minor(device);
> out:
> module_put(discipline->owner);
> return rc;
Seems correct to me, if tape_assign_minor fails (e.g. because of too
many devices) then the function will try to remove the minor again
which is not registered. Nothing bad happens because tape_alloc_device
will initialize the list head but still. I'll add it to my patch queue.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
parent reply other threads:[~2009-08-22 20:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <4A9006A1.7010706@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090822223243.0a667bd0@skybase \
--to=schwidefsky@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.