From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfAGL-0000tz-Li for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 06:25:25 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfAGI-0000rg-3B for grub-devel@gnu.org; Sun, 23 Aug 2009 06:25:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfAGC-0000pj-Ck for grub-devel@gnu.org; Sun, 23 Aug 2009 06:25:20 -0400 Received: from [199.232.76.173] (port=50680 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfAGC-0000pb-69 for grub-devel@gnu.org; Sun, 23 Aug 2009 06:25:16 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:60252 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfAGA-0000wQ-8y for grub-devel@gnu.org; Sun, 23 Aug 2009 06:25:15 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfAG7-00075q-72 for grub-devel@gnu.org; Sun, 23 Aug 2009 12:25:12 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfAFz-0001Ic-MP for grub-devel@gnu.org; Sun, 23 Aug 2009 12:25:03 +0200 Date: Sun, 23 Aug 2009 12:25:03 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090823102503.GB4130@thorin> References: <20090817135146.GN32551@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 10:25:22 -0000 On Fri, Aug 21, 2009 at 02:54:32PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 17, 2009 at 3:51 PM, Robert Millan wrote: > > On Sun, Aug 16, 2009 at 08:51:06PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> After discussion on IRC it revealed that hook-based approach is > >> unpracticable because number of available modes grows exponentially > >> with every parameter available. Here is the patch to change to > >> flag-based approach > > > > Please can you ellaborate on this?  (if you still have a copy of the > > discussion, it'd be useful to post it) > > > There was no discussion on this point. But current design is to call a > hook with every available mode and see if it approves the mode. > Unfortunately it doesn't work as expected because some modes aren't > presented by driver unless explicitly requested. This may cause > appropriate mode to be missed. Making driver iterate through a lot of > modes will slow down mode switching. With flag-based approach driver > knows which mode upper layer wants and so can present appropriate one. > It has a drawback of limiting number of filtering possibilities but > currently no subsystem needs more than is done with this patch. If it > changes in the future interface can be extended to have new flags or > parameters Thank you. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."