From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfALF-0004ut-BY for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 06:30:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfALC-0004uK-Vl for grub-devel@gnu.org; Sun, 23 Aug 2009 06:30:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfAL7-0004qE-FK for grub-devel@gnu.org; Sun, 23 Aug 2009 06:30:25 -0400 Received: from [199.232.76.173] (port=53815 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfAL7-0004qA-9b for grub-devel@gnu.org; Sun, 23 Aug 2009 06:30:21 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:35292 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfAL6-0001XU-Fr for grub-devel@gnu.org; Sun, 23 Aug 2009 06:30:21 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfAL2-0007AG-NF for grub-devel@gnu.org; Sun, 23 Aug 2009 12:30:18 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfAKw-0001RY-EC for grub-devel@gnu.org; Sun, 23 Aug 2009 12:30:10 +0200 Date: Sun, 23 Aug 2009 12:30:10 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090823103010.GC4130@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH 1/2] Replace hook-based with flag-based approach for choosing video mode X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 10:30:27 -0000 I've only one comment, the rest looks fine. Btw, please include a ChangeLog entry next time. On Sun, Aug 16, 2009 at 08:51:06PM +0200, Vladimir 'phcoder' Serbinenko wrote: > diff --git a/commands/videotest.c b/commands/videotest.c > index 6fe4b9b..07f61bd 100644 > --- a/commands/videotest.c > +++ b/commands/videotest.c > @@ -30,7 +30,8 @@ grub_cmd_videotest (grub_command_t cmd __attribute__ ((unused)), > int argc __attribute__ ((unused)), > char **args __attribute__ ((unused))) > { > - if (grub_video_set_mode ("1024x768;800x600;640x480", 0) != GRUB_ERR_NONE) > + if (grub_video_set_mode ("1024x768;800x600;640x480", > + GRUB_VIDEO_MODE_TYPE_PURE_TEXT, 0) != GRUB_ERR_NONE) > return grub_errno; > [...] > grub_err_t grub_video_set_mode (const char *modestring, > - int NESTED_FUNC_ATTR (*hook) (grub_video_adapter_t p, > - struct grub_video_mode_info *mode_info)); > + unsigned int modemask, > + unsigned int modevalue); People usually associate "pure text" mode with a managed mode like 80x25 vga text. I understand here it means something else, but is there some way this could be clearer? Perhaps a different macro name or a comment. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."