From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfAcY-0007RG-Gz for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 06:48:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfAcW-0007Qs-8N for grub-devel@gnu.org; Sun, 23 Aug 2009 06:48:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfAcR-0007Nd-MI for grub-devel@gnu.org; Sun, 23 Aug 2009 06:48:19 -0400 Received: from [199.232.76.173] (port=46064 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfAcR-0007NY-HG for grub-devel@gnu.org; Sun, 23 Aug 2009 06:48:15 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:51986 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfAcR-0003ud-2K for grub-devel@gnu.org; Sun, 23 Aug 2009 06:48:15 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfAcP-0007Vx-57 for grub-devel@gnu.org; Sun, 23 Aug 2009 12:48:13 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfAcO-0001uo-Rd for grub-devel@gnu.org; Sun, 23 Aug 2009 12:48:12 +0200 Date: Sun, 23 Aug 2009 12:48:12 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090823104812.GG4130@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Optimised 1bit blitters X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 10:48:20 -0000 On Fri, Aug 21, 2009 at 05:33:30PM +0200, Vladimir 'phcoder' Serbinenko wrote: > + for (j = 0; j < height; j++) > + { > + for (i = 0; i < width; i++) > + { It's a bit odd, but GCC doesn't seem to optimize those in a single loop. Could you use "i = 0; i < height * width; i++" instead? (for this and the other similar instances) I can't comment much on the rest of this patch, as my understanding of graphics is limited. But please wait a few days before commit, hopefully someone else will review. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."