From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfAhf-0006ay-VH for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 06:53:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfAhd-0006XI-Ka for grub-devel@gnu.org; Sun, 23 Aug 2009 06:53:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfAhZ-0006Sp-3b for grub-devel@gnu.org; Sun, 23 Aug 2009 06:53:37 -0400 Received: from [199.232.76.173] (port=56836 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfAhY-0006Sa-WB for grub-devel@gnu.org; Sun, 23 Aug 2009 06:53:33 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:40162 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfAhY-0004pw-Hc for grub-devel@gnu.org; Sun, 23 Aug 2009 06:53:32 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfAhW-0007aW-Q5 for grub-devel@gnu.org; Sun, 23 Aug 2009 12:53:31 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfAhW-0001vF-Mx for grub-devel@gnu.org; Sun, 23 Aug 2009 12:53:30 +0200 Date: Sun, 23 Aug 2009 12:53:30 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090823105330.GI4130@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Use extcmd to handle bsd arguments. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 10:53:37 -0000 On Sat, Aug 22, 2009 at 02:22:24PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Hello. Currently bsd loaders inspects argv[1] for boot options but the > treat argv[1] as if it always was prefixed by dash ('-') and > completely ignores options in argv[n], n>1. This leads to unexpected > results like > freebsd /kernel verbose > is parsed like verbose ('v'), dfltroot ('r') and single ('s') > freebsd /kernel -v -s > is parsed only like verbose and not verbose and single. > Additionally help shows no information about these options. This patch > delegates option parsing to lib/arg.c and so achieves good option > passing, GNU-style options support and provides help. Unfortunately > booting with some options has no noticeable effect so I couldn't > document what they do Please go ahead (I assume you've tested it on the 3 *BSD kernels). Btw, you capitalized two of the "Load kernel of ..." messages but not the NetBSD one: > + cmd_freebsd = grub_register_extcmd ("freebsd", grub_cmd_freebsd, > + GRUB_COMMAND_FLAG_BOTH, > + "freebsd FILE", "Load kernel of FreeBSD.", > + freebsd_opts); > + cmd_openbsd = grub_register_extcmd ("openbsd", grub_cmd_openbsd, > + GRUB_COMMAND_FLAG_BOTH, > + "openbsd FILE", "Load kernel of OpenBSD.", > + openbsd_opts); > + cmd_netbsd = grub_register_extcmd ("netbsd", grub_cmd_netbsd, > + GRUB_COMMAND_FLAG_BOTH, > + "netbsd FILE", "load kernel of NetBSD", > + netbsd_opts); -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."