From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1MfAlY-0001Qs-TY
	for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 06:57:40 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MfAlX-0001Op-LS
	for grub-devel@gnu.org; Sun, 23 Aug 2009 06:57:39 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MfAlT-0001Ju-SH
	for grub-devel@gnu.org; Sun, 23 Aug 2009 06:57:39 -0400
Received: from [199.232.76.173] (port=34364 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MfAlT-0001JV-Mw
	for grub-devel@gnu.org; Sun, 23 Aug 2009 06:57:35 -0400
Received: from xvm-190-8.ghst.net ([217.70.190.8]:51796 helo=aybabtu.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1MfAlT-0005Vi-6A
	for grub-devel@gnu.org; Sun, 23 Aug 2009 06:57:35 -0400
Received: from [192.168.10.10] (helo=thorin)
	by aybabtu.com with esmtp (Exim 4.69)
	(envelope-from <rmh@aybabtu.com>) id 1MfAlR-0007e0-Mb
	for grub-devel@gnu.org; Sun, 23 Aug 2009 12:57:33 +0200
Received: from rmh by thorin with local (Exim 4.69)
	(envelope-from <rmh@aybabtu.com>) id 1MfAlQ-0001vs-Qj
	for grub-devel@gnu.org; Sun, 23 Aug 2009 12:57:32 +0200
Date: Sun, 23 Aug 2009 12:57:32 +0200
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20090823105732.GJ4130@thorin>
References: <d7ead6de0908220733td135723jdfc2e42202687ae6@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d7ead6de0908220733td135723jdfc2e42202687ae6@mail.gmail.com>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.18 (2008-05-17)
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
Subject: Re: [PATCH] Replace ad-hoc format in efiemu (for variables) and
	XNU (for device tree) by environment variables
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Aug 2009 10:57:40 -0000

On Sat, Aug 22, 2009 at 04:33:13PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> [...]
> +
> +pkglib_MODULES += utf.mod
> +utf_mod_SOURCES = lib/utf.c
> +utf_mod_CFLAGS = $(COMMON_CFLAGS)
> +utf_mod_LDFLAGS = $(COMMON_LDFLAGS)
> [...]
> +#include <grub/utf.h>
> +
> +grub_ssize_t
> +grub_utf8_to_utf16 (grub_uint16_t *dest, grub_size_t destsize,
> +		    const grub_uint8_t *src, grub_size_t srcsize,
> +		    const grub_uint8_t **srcend)
> +{

This was moved from another file, right?  Please could you send it as a
separate patch?

Also, please remember to include a ChangeLog entry.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."