From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfAvb-0000eo-Q6 for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 07:08:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfAvZ-0000b2-Ko for grub-devel@gnu.org; Sun, 23 Aug 2009 07:08:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfAvV-0000T5-TW for grub-devel@gnu.org; Sun, 23 Aug 2009 07:08:01 -0400 Received: from [199.232.76.173] (port=50964 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfAvV-0000Se-NA for grub-devel@gnu.org; Sun, 23 Aug 2009 07:07:57 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:38624 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfAvV-0007IQ-7Y for grub-devel@gnu.org; Sun, 23 Aug 2009 07:07:57 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfAvT-0007nC-KS for grub-devel@gnu.org; Sun, 23 Aug 2009 13:07:55 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfAvT-0001xm-2L for grub-devel@gnu.org; Sun, 23 Aug 2009 13:07:55 +0200 Date: Sun, 23 Aug 2009 13:07:55 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090823110755.GN4130@thorin> References: <20090817134639.GJ32551@thorin> <20090819152224.GD7859@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090819152224.GD7859@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [GITGRUB] FB driver for EFI X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 11:08:01 -0000 On Wed, Aug 19, 2009 at 05:22:24PM +0200, Robert Millan wrote: > On Tue, Aug 18, 2009 at 09:26:45PM +0800, Bean wrote: > > Hi, > > > > Here is the raw patch. > > Thanks. Was efi_fb.c written from scratch, or copied/refurbished from another > part of GRUB ? It's ok either way, but we need to know about it. Would you > please send a ChangeLog entry where this is referenced? > > (and in general, please include ChangeLog entries when submitting patches) Btw, the patch itself looks fine to me. When you commit it, please make sure its ChangeLog entry documents whether this was moved from another part of GRUB or is new code. In the future, please include ChangeLog entries when submitting patches. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."