All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] exofs: remove BKL from super operations
Date: Sun, 23 Aug 2009 15:31:07 +0200	[thread overview]
Message-ID: <20090823133107.GA25220@lst.de> (raw)
In-Reply-To: <4A91305E.1030909@panasas.com>

On Sun, Aug 23, 2009 at 03:04:46PM +0300, Boaz Harrosh wrote:
> On 08/20/2009 02:49 AM, Christoph Hellwig wrote:
> > Any chance you could also remove the lock_super usage once your start
> > revisiting the lock?  lock_super is never taken by the VFS anymore, so
> > you can easily replace it with fs-local locking.
> > 
> 
> OK Sure, thanks.
> 
> One question please?
> 
> I need a mutex_lock I can sleep on. Could I use the inode_lock associate
> with the root_inode. Or that could lead to dead-locks with the VFS?

It could lead to all kinds of lock dependency problems no one even
thinks about.

> (Or should I just allocate another mutex at the fs-sb-data?)

Yes.


  reply	other threads:[~2009-08-23 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-19 14:56 [PATCH] exofs: remove BKL from super operations Boaz Harrosh
2009-08-19 23:49 ` Christoph Hellwig
2009-08-23 12:04   ` Boaz Harrosh
2009-08-23 13:31     ` Christoph Hellwig [this message]
2009-08-23 13:40       ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090823133107.GA25220@lst.de \
    --to=hch@lst.de \
    --cc=bharrosh@panasas.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.