From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfLXY-0002T2-8X for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 18:27:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfLXV-0002QE-Hq for grub-devel@gnu.org; Sun, 23 Aug 2009 18:27:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfLXR-0002NN-6t for grub-devel@gnu.org; Sun, 23 Aug 2009 18:27:53 -0400 Received: from [199.232.76.173] (port=35153 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfLXR-0002NG-0N for grub-devel@gnu.org; Sun, 23 Aug 2009 18:27:49 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:40475 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfLXQ-0004Q7-Is for grub-devel@gnu.org; Sun, 23 Aug 2009 18:27:48 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfLXO-0001Bj-6c; Mon, 24 Aug 2009 00:27:46 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfLXN-0006h2-EB; Mon, 24 Aug 2009 00:27:45 +0200 Date: Mon, 24 Aug 2009 00:27:45 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090823222745.GA25665@thorin> References: <20090812153520.GA11691@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090812153520.GA11691@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: Colin Watson Subject: Re: [PATCH] Detect key modifier status in 'sleep --interruptible' X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 22:27:54 -0000 On Wed, Aug 12, 2009 at 04:35:21PM +0100, Colin Watson wrote: > +static int > +grub_at_keyboard_keystatus (void) > +{ > + /* FIXME: I don't know if getting key modifier status is possible without > + * BIOS help. */ > + return 0; > +} > + What we do in these cases is leave the function pointer undefined, which means NULL value (and check this in the caller of course). But in at_keyboard it's definitely possible (check how we handle e.g. CTRL or SHIFT keys). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."