From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfLzG-00080h-0Y for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 18:56:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfLzE-000802-3F for grub-devel@gnu.org; Sun, 23 Aug 2009 18:56:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfLz9-0007yw-TV for grub-devel@gnu.org; Sun, 23 Aug 2009 18:56:31 -0400 Received: from [199.232.76.173] (port=39949 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfLz9-0007yc-CH for grub-devel@gnu.org; Sun, 23 Aug 2009 18:56:27 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:34433 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfLz7-0001Pi-Q4 for grub-devel@gnu.org; Sun, 23 Aug 2009 18:56:26 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfLz6-0001Jo-4S for grub-devel@gnu.org; Mon, 24 Aug 2009 00:56:24 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfLz5-0006lc-9X for grub-devel@gnu.org; Mon, 24 Aug 2009 00:56:23 +0200 Date: Mon, 24 Aug 2009 00:56:23 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090823225623.GD25769@thorin> References: <20090812153520.GA11691@riva.ucam.org> <20090812221431.GD11691@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Detect key modifier status in 'sleep --interruptible' X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 22:56:32 -0000 On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko wrote: > Why is it still asm? It can be done easily in C. > Actually here we have 2 extremes: nice code (C, transform to nice > flags (only one shift or 2 conrols and alts)) or small code (asm, > crude value). Where we choose the compromise is a question for > maintainer, not me. Nice code, please. We're pressed for space, but not *that* much. Besides, we can't use this asm code as-is, unless we get word from the people who wrote it (Colin wrote most of the patch, but not this). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."