From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfM5j-0002by-Sb for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 19:03:15 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfM5i-0002au-Kh for grub-devel@gnu.org; Sun, 23 Aug 2009 19:03:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfM5d-0002Vb-VP for grub-devel@gnu.org; Sun, 23 Aug 2009 19:03:14 -0400 Received: from [199.232.76.173] (port=48872 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfM5d-0002VT-PR for grub-devel@gnu.org; Sun, 23 Aug 2009 19:03:09 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:42048 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfM5d-0002Ug-F7 for grub-devel@gnu.org; Sun, 23 Aug 2009 19:03:09 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfM5b-0001KX-Ld for grub-devel@gnu.org; Mon, 24 Aug 2009 01:03:07 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfM5a-0006mp-Qx for grub-devel@gnu.org; Mon, 24 Aug 2009 01:03:06 +0200 Date: Mon, 24 Aug 2009 01:03:06 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090823230306.GB26040@thorin> References: <20090812153520.GA11691@riva.ucam.org> <20090812221431.GD11691@riva.ucam.org> <20090823225623.GD25769@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Detect key modifier status in 'sleep --interruptible' X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 23:03:14 -0000 On Mon, Aug 24, 2009 at 01:00:06AM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Mon, Aug 24, 2009 at 12:56 AM, Robert Millan wrote: > > On Mon, Aug 24, 2009 at 12:46:29AM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> Why is it still asm? It can be done easily in C. > >> Actually here we have 2 extremes: nice code (C, transform to nice > >> flags (only one shift or 2 conrols and alts)) or small code (asm, > >> crude value). Where we choose the compromise is a question for > >> maintainer, not me. > > > > Nice code, please.  We're pressed for space, but not *that* much. > > > > Besides, we can't use this asm code as-is, unless we get word from the > > people who wrote it (Colin wrote most of the patch, but not this). > > > In this case we don't need asm at all. I didn't look much into this. I thought there was a new BIOS call being introduced? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."