From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfMA6-00076o-MK for mharc-grub-devel@gnu.org; Sun, 23 Aug 2009 19:07:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfMA4-00073G-Cg for grub-devel@gnu.org; Sun, 23 Aug 2009 19:07:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfM9z-0006vA-FV for grub-devel@gnu.org; Sun, 23 Aug 2009 19:07:43 -0400 Received: from [199.232.76.173] (port=37381 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfM9y-0006uk-SM for grub-devel@gnu.org; Sun, 23 Aug 2009 19:07:38 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:51485 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfM9y-00031E-N4 for grub-devel@gnu.org; Sun, 23 Aug 2009 19:07:38 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfM9w-0001Kr-MM for grub-devel@gnu.org; Mon, 24 Aug 2009 01:07:36 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfM9w-0006oA-4d for grub-devel@gnu.org; Mon, 24 Aug 2009 01:07:36 +0200 Date: Mon, 24 Aug 2009 01:07:36 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090823230736.GA26096@thorin> References: <20090823104812.GG4130@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Optimised 1bit blitters X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Aug 2009 23:07:44 -0000 On Sun, Aug 23, 2009 at 01:05:45PM +0200, Vladimir 'phcoder' Serbinenko wrote: > On Sun, Aug 23, 2009 at 12:48 PM, Robert Millan wrote: > > On Fri, Aug 21, 2009 at 05:33:30PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> +  for (j = 0; j < height; j++) > >> +    { > >> +      for (i = 0; i < width; i++) > >> +        { > > > > It's a bit odd, but GCC doesn't seem to optimize those in a single loop.  Could > > you use "i = 0; i < height * width; i++" instead?  (for this and the other > > similar instances) > There are some operations to do after completing inner loop. Oh, right. Sorry I missread it. In that case, I have no objection but please let it rest a few days to see if someone else will review it. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."