Re: [PATCH] Clean up struct grub_module_header

[Robert Millan <rmh@aybabtu.com>]

On Sun, Aug 23, 2009 at 01:08:05PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Sun, Aug 23, 2009 at 12:50 PM, Robert Millan<rmh@aybabtu.com> wrote:
> > On Sat, Aug 22, 2009 at 02:10:12AM -0400, Pavel Roskin wrote:
> >> +enum
> >> +{
> >> +  OBJ_TYPE_ELF,
> >> +  OBJ_TYPE_MEMDISK,
> >> +  OBJ_TYPE_CONFIG
> >> +};
> >
> > Do we actually use OBJ_TYPE_CONFIG ?  I think it's there in the framework,
> > but we don't provide any means to use it.  Instead, grub-mkrescue puts grub.cfg
> > in the memdisk filesystem.
> >
> > Does it even make sense to support this object type?  AFAICT the situation has
> > been like this for a long while and nobody complained.
> >
> Actually OBJ_TYPE_CONFIG is useful and it provides a way to execute a
> file with rescue parser before other parsers are available. It's
> useful to find root in special configurations. One of my TODO items is
> to replace (UUID=...)/ syntax with using search command based on this
> feature

Ok.  I'm not very fond of the (UUID=...) hack either (yeah, I guess I'm the
one to blame for it).

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."