From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix race copy_process() vs de_thread()
Date: Mon, 24 Aug 2009 12:50:54 +0200 [thread overview]
Message-ID: <20090824105054.GA6966@redhat.com> (raw)
In-Reply-To: <20090824091558.BDAFE414DF@magilla.sf.frob.com>
On 08/24, Roland McGrath wrote:
>
> I think I like your first patch better. It's a larger patch, but that's
> because it winds up with smaller code.
Yes, agreed.
And another reason for the first patch: ->live should not be used as a refcnt,
it is not. This should work for copy_process() but looks confusing and relies
on CLONE_THREAD subtleness anyway.
I'll re-check this patch and resend. I guess -stable needs this fix too.
Oleg.
next prev parent reply other threads:[~2009-08-24 10:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 4:01 [PATCH] fix race copy_process() vs de_thread() Hiroshi Shimamoto
2009-08-24 5:11 ` KAMEZAWA Hiroyuki
2009-08-24 5:58 ` [PATCH v2] " Hiroshi Shimamoto
2009-08-24 6:14 ` [PATCH] " Roland McGrath
2009-08-24 6:20 ` Roland McGrath
2009-08-24 6:32 ` Hiroshi Shimamoto
2009-08-24 8:38 ` Oleg Nesterov
2009-08-24 8:53 ` Oleg Nesterov
2009-08-24 9:15 ` Roland McGrath
2009-08-24 10:50 ` Oleg Nesterov [this message]
2009-08-24 16:27 ` [PATCH v3] " Oleg Nesterov
2009-08-24 16:57 ` Roland McGrath
2009-08-25 0:10 ` Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090824105054.GA6966@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.