From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MfZ6R-0005cV-WD for mharc-grub-devel@gnu.org; Mon, 24 Aug 2009 08:56:52 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MfZ6P-0005ZP-Tt for grub-devel@gnu.org; Mon, 24 Aug 2009 08:56:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MfZ6L-0005S7-3Z for grub-devel@gnu.org; Mon, 24 Aug 2009 08:56:49 -0400 Received: from [199.232.76.173] (port=51385 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MfZ6K-0005Rq-QS for grub-devel@gnu.org; Mon, 24 Aug 2009 08:56:44 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:52379 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MfZ6K-0001AP-90 for grub-devel@gnu.org; Mon, 24 Aug 2009 08:56:44 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MfZ6I-0003PJ-J0 for grub-devel@gnu.org; Mon, 24 Aug 2009 14:56:42 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MfZ6H-0005EY-QK for grub-devel@gnu.org; Mon, 24 Aug 2009 14:56:41 +0200 Date: Mon, 24 Aug 2009 14:56:41 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090824125641.GA20080@thorin> References: <20090812153520.GA11691@riva.ucam.org> <20090812221431.GD11691@riva.ucam.org> <20090824092406.GE11691@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090824092406.GE11691@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Detect key modifier status in 'sleep --interruptible' X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2009 12:56:50 -0000 On Mon, Aug 24, 2009 at 10:24:06AM +0100, Colin Watson wrote: > diff -Nur -x '*.orig' -x '*~' grub2-1.96+20090725/term/ieee1275/ofconsole.c grub2-1.96+20090725.new/term/ieee1275/ofconsole.c > --- grub2-1.96+20090725/term/ieee1275/ofconsole.c 2009-06-10 22:04:23.000000000 +0100 > +++ grub2-1.96+20090725.new/term/ieee1275/ofconsole.c 2009-08-24 10:17:58.000000000 +0100 > @@ -396,6 +396,8 @@ > .fini = grub_ofconsole_fini, > .checkkey = grub_ofconsole_checkkey, > .getkey = grub_ofconsole_getkey, > + /* No attempt to support this for Open Firmware yet. */ > + .keystatus = NULL, > }; Btw, I ommitted this from the last patch I sent, as it is unnecessary. The BSS is zero'ed before grub_main() so all uninitialized variables are implicitly 0. In this kind of structs, when a member is optional and we don't implement it, we just skip it. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."