All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] Clean up upcast from PCIDevice to I6300State
Date: Mon, 24 Aug 2009 12:59:06 +0100	[thread overview]
Message-ID: <200908241259.06409.paul@codesourcery.com> (raw)
In-Reply-To: <1250843494-28326-3-git-send-email-armbru@redhat.com>

>  /* Device state. */
>  struct I6300State {
> -    PCIDevice dev;             /* PCI device state, must be first field. */
> +    PCIDevice dev;
>...
> -    I6300State *d = (I6300State *) dev;
> +    I6300State *d = container_of(dev, I6300State, dev);

I'm pretty sure this is wrong, and code elsewhere still requires the PCIDevice 
be the first field in I6300State. e.g. i6300esb_pc_init. Did you actually try 
putting dev at a nonzero offset?

Paul

  parent reply	other threads:[~2009-08-24 11:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-21  8:31 [Qemu-devel] [PATCH 0/3] qdev: clean up & convert watchdogs Markus Armbruster
2009-08-21  8:31 ` [Qemu-devel] [PATCH 1/3] Move watchdog, watchdog_action, give them internal linkage Markus Armbruster
2009-08-21  8:31 ` [Qemu-devel] [PATCH 2/3] Clean up upcast from PCIDevice to I6300State Markus Armbruster
     [not found]   ` <m3ws4xt7up.fsf@neno.mitica>
2009-08-24  8:49     ` [Qemu-devel] container_of() vs DO_UPCAST() (was: [PATCH 2/3] Clean up upcast from PCIDevice to I6300State) Markus Armbruster
2009-08-24 11:55       ` Paul Brook
2009-08-24 11:59   ` Paul Brook [this message]
2009-08-24 13:44     ` [Qemu-devel] [PATCH 2/3] Clean up upcast from PCIDevice to I6300State Markus Armbruster
2009-08-24 15:07       ` Gerd Hoffmann
2009-08-21  8:31 ` [Qemu-devel] [PATCH 3/3] qdev: convert watchdogs Markus Armbruster
2009-08-21 13:07   ` Gerd Hoffmann
2009-08-24  9:05     ` Immutable qdev properties (was: [Qemu-devel] [PATCH 3/3] qdev: convert watchdogs) Markus Armbruster
2009-08-24 12:25       ` [Qemu-devel] Re: Immutable qdev properties Gerd Hoffmann
2009-08-24 13:04         ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908241259.06409.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.