From: Frederic Weisbecker <fweisbec@gmail.com>
To: Josh Stone <jistone@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jason Baron <jbaron@redhat.com>,
Ingo Molnar <mingo@elte.hu>, Li Zefan <lizf@cn.fujitsu.com>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Jiaying Zhang <jiayingz@google.com>,
Martin Bligh <mbligh@google.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH v3 2/4] tracing: Make syscall_(un)regfunc arch-specific
Date: Mon, 24 Aug 2009 21:58:01 +0200 [thread overview]
Message-ID: <20090824195759.GA5050@nowhere> (raw)
In-Reply-To: <4A92EA8E.8020400@redhat.com>
On Mon, Aug 24, 2009 at 12:31:26PM -0700, Josh Stone wrote:
> On 08/23/2009 02:14 PM, Frederic Weisbecker wrote:
> > I really don't like that.
> > See how the s390 and x86 version of the above code are completely
> > identical?
> >
> > Please put this in kernel/ptrace.c
>
> Yes, I see your point, and I think kernel/ptrace.c is a fine place for
> it. Making it conditional on CONFIG_TRACEPOINTS and
> CONFIG_HAVE_FTRACE_SYSCALLS is probably best too, though I think the
> latter should now be HAVE_SYSCALL_TRACEPOINTS.
As you prefer, this new name can be indeed more verbose.
Thanks.
> Thanks,
>
> Josh
next prev parent reply other threads:[~2009-08-24 19:58 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 7:23 [PATCH] tracing: Move tracepoint callbacks into DEFINE Josh Stone
2009-08-18 14:19 ` Jason Baron
2009-08-18 22:11 ` Josh Stone
2009-08-18 22:25 ` [PATCH] tracing: Create generic syscall TRACE_EVENTs Josh Stone
2009-08-19 1:32 ` Li Zefan
2009-08-19 3:05 ` Josh Stone
2009-08-19 13:05 ` Ingo Molnar
2009-08-19 13:50 ` Mathieu Desnoyers
2009-08-19 16:16 ` Jason Baron
2009-08-19 17:43 ` Frederic Weisbecker
2009-08-19 16:13 ` [PATCH] tracing: Move tracepoint callbacks into DEFINE Jason Baron
2009-08-20 17:25 ` Josh Stone
2009-08-20 19:09 ` [PATCH v2 1/2] " Josh Stone
2009-08-20 19:09 ` [PATCH v2 2/2] tracing: Create generic syscall TRACE_EVENTs Josh Stone
2009-08-21 17:57 ` Jason Baron
2009-08-21 19:37 ` Josh Stone
2009-08-21 20:08 ` Jason Baron
2009-08-21 14:47 ` [PATCH v2 1/2] tracing: Move tracepoint callbacks into DEFINE Ingo Molnar
2009-08-21 19:34 ` Josh Stone
2009-08-21 17:52 ` Jason Baron
2009-08-21 19:34 ` Josh Stone
2009-08-21 20:06 ` Jason Baron
2009-08-23 20:29 ` Frederic Weisbecker
2009-08-23 20:15 ` Frederic Weisbecker
2009-08-22 4:58 ` [PATCH v3 0/4] tracing: tweaks for generic syscall events Josh Stone
2009-08-22 4:58 ` [PATCH v3 1/4] tracing: Rename TIF_SYSCALL_FTRACE->_TRACEPOINT Josh Stone
2009-08-22 4:58 ` [PATCH v3 2/4] tracing: Make syscall_(un)regfunc arch-specific Josh Stone
2009-08-22 4:58 ` [PATCH v3 3/4] tracing: Move tracepoint callbacks into DEFINE Josh Stone
2009-08-22 4:58 ` [PATCH v3 4/4] tracing: Create generic syscall TRACE_EVENTs Josh Stone
2009-08-23 21:14 ` [PATCH v3 2/4] tracing: Make syscall_(un)regfunc arch-specific Frederic Weisbecker
2009-08-24 1:40 ` Paul Mundt
2009-08-24 8:41 ` Ingo Molnar
2009-08-24 8:59 ` Paul Mundt
2009-08-24 9:56 ` Ingo Molnar
2009-08-24 10:32 ` Paul Mundt
2009-08-24 11:00 ` Ingo Molnar
2009-08-24 11:15 ` Paul Mundt
2009-08-24 11:32 ` Ingo Molnar
2009-08-24 11:52 ` Ingo Molnar
2009-08-24 12:14 ` Peter Zijlstra
2009-08-24 11:01 ` Ingo Molnar
2009-08-24 11:02 ` Paul Mundt
2009-08-24 19:31 ` Josh Stone
2009-08-24 19:58 ` Frederic Weisbecker [this message]
2009-08-24 20:00 ` Josh Stone
2009-08-24 20:12 ` Frederic Weisbecker
2009-08-23 21:16 ` [PATCH v3 1/4] tracing: Rename TIF_SYSCALL_FTRACE->_TRACEPOINT Frederic Weisbecker
2009-08-24 8:42 ` Ingo Molnar
2009-08-24 11:11 ` Frederic Weisbecker
2009-08-24 11:24 ` Ingo Molnar
2009-08-24 11:29 ` Paul Mundt
2009-08-24 11:36 ` Ingo Molnar
2009-08-24 21:43 ` [PATCH v4 0/4] tracing: tweaks for generic syscall events Josh Stone
2009-08-24 21:43 ` [PATCH v4 1/4] tracing: Rename FTRACE_SYSCALLS for tracepoints Josh Stone
2009-08-24 21:43 ` [PATCH v4 2/4] tracing: Make syscall tracepoints conditional Josh Stone
2009-08-24 21:43 ` [PATCH v4 3/4] tracing: Move tracepoint callbacks into DEFINE Josh Stone
2009-08-24 21:43 ` [PATCH v4 4/4] tracing: Create generic syscall TRACE_EVENTs Josh Stone
2009-08-26 7:22 ` [tip:tracing/core] " tip-bot for Josh Stone
2009-08-26 7:22 ` [tip:tracing/core] tracing: Move tracepoint callbacks from declaration to definition tip-bot for Josh Stone
2009-08-27 22:50 ` [PATCH] tracing: Fix double CPP substitution in TRACE_EVENT_FN Frederic Weisbecker
2009-08-28 0:38 ` Josh Stone
2009-08-28 12:29 ` [tip:tracing/core] " tip-bot for Frederic Weisbecker
2009-08-26 7:21 ` [tip:tracing/core] tracing: Make syscall tracepoints conditional tip-bot for Josh Stone
2009-08-26 7:21 ` [tip:tracing/core] tracing: Rename FTRACE_SYSCALLS for tracepoints tip-bot for Josh Stone
2009-08-24 23:05 ` [PATCH v4 0/4] tracing: tweaks for generic syscall events Frederic Weisbecker
2009-08-25 10:28 ` Ingo Molnar
2009-08-25 13:42 ` Frederic Weisbecker
2009-08-25 14:41 ` Jason Baron
2009-08-25 21:08 ` Frederic Weisbecker
2009-08-25 21:44 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090824195759.GA5050@nowhere \
--to=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=jiayingz@google.com \
--cc=jistone@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.