From: Paul Mundt <lethal@linux-sh.org>
To: Jason Baron <jbaron@redhat.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, fweisbec@gmail.com,
mingo@elte.hu, laijs@cn.fujitsu.com, rostedt@goodmis.org,
peterz@infradead.org, mathieu.desnoyers@polymtl.ca,
jiayingz@google.com, mbligh@google.com, lizf@cn.fujitsu.com,
jistone@redhat.com, tglx@linutronix.de, hpa@zytor.com
Subject: Re: [PATCH 1/4] add NR_syscalls define for x86
Date: Tue, 25 Aug 2009 07:05:32 +0900 [thread overview]
Message-ID: <20090824220531.GA20832@linux-sh.org> (raw)
In-Reply-To: <0f33c0f96d198fccc3ddd9ff7f5334ff5cb42706.1251146513.git.jbaron@redhat.com>
On Mon, Aug 24, 2009 at 05:40:14PM -0400, Jason Baron wrote:
> Add a NR_syscalls #define for x86. This is used in the syscall events tracing
> code. Todo: make it dynamic like x86_64
>
> Signed-off-by: Jason Baron <jbaron@redhat.com>
>
>
> ---
> arch/x86/include/asm/unistd_32.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/include/asm/unistd_32.h b/arch/x86/include/asm/unistd_32.h
> index 732a307..8deaada 100644
> --- a/arch/x86/include/asm/unistd_32.h
> +++ b/arch/x86/include/asm/unistd_32.h
> @@ -345,6 +345,8 @@
>
> #ifdef __KERNEL__
>
> +#define NR_syscalls 337
> +
Syscalls start at 0 and end at 337, there are 338 syscalls, not 337.
Hence the off-by-1 that I initially reported. NR_syscalls is always the
last syscall + 1.
next prev parent reply other threads:[~2009-08-24 22:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 21:40 [PATCH 0/4] use NR_syscalls instead of FTRACE_SYSCALL_MAX Jason Baron
2009-08-24 21:40 ` [PATCH 1/4] add NR_syscalls define for x86 Jason Baron
2009-08-24 22:05 ` Paul Mundt [this message]
2009-08-25 13:37 ` Jason Baron
2009-08-28 12:28 ` [tip:tracing/core] tracing: Define NR_syscalls for x86 (32) tip-bot for Jason Baron
2009-08-24 21:40 ` [PATCH 2/4] Add NR_syscalls for x86_64 Jason Baron
2009-08-24 22:14 ` Frederic Weisbecker
2009-08-24 22:44 ` Steven Rostedt
2009-08-25 13:40 ` Jason Baron
2009-08-25 18:47 ` Jason Baron
2009-08-25 19:04 ` Mathieu Desnoyers
2009-08-25 20:58 ` Jason Baron
2009-08-25 23:28 ` Mathieu Desnoyers
2009-08-25 23:38 ` Frederic Weisbecker
2009-08-26 2:25 ` Steven Rostedt
2009-08-26 13:58 ` Jason Baron
2009-08-26 14:39 ` Steven Rostedt
2009-08-26 16:09 ` Jason Baron
2009-08-26 16:21 ` Steven Rostedt
2009-08-26 16:29 ` Frederic Weisbecker
2009-08-26 16:24 ` Frederic Weisbecker
2009-08-28 12:28 ` [tip:tracing/core] tracing: Define " tip-bot for Jason Baron
2009-08-24 21:40 ` [PATCH 3/4] Convert event tracing code to NR_syscalls Jason Baron
2009-08-28 12:28 ` [tip:tracing/core] tracing: Convert event tracing code to use NR_syscalls tip-bot for Jason Baron
2009-08-24 21:40 ` [PATCH 4/4] remove FTRACE_SYSCALL_MAX definitions Jason Baron
2009-08-28 12:28 ` [tip:tracing/core] tracing: Remove " tip-bot for Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090824220531.GA20832@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jbaron@redhat.com \
--cc=jiayingz@google.com \
--cc=jistone@redhat.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mbligh@google.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.