From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mg6QO-0001cX-8J for mharc-grub-devel@gnu.org; Tue, 25 Aug 2009 20:31:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mg6QN-0001cA-H3 for grub-devel@gnu.org; Tue, 25 Aug 2009 20:31:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mg6QI-0001a0-Q7 for grub-devel@gnu.org; Tue, 25 Aug 2009 20:31:38 -0400 Received: from [199.232.76.173] (port=60238 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mg6QI-0001Zv-HH for grub-devel@gnu.org; Tue, 25 Aug 2009 20:31:34 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:49622 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mg6QI-0008Iz-3S for grub-devel@gnu.org; Tue, 25 Aug 2009 20:31:34 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mg6QG-0000ki-3L for grub-devel@gnu.org; Wed, 26 Aug 2009 02:31:32 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mg6QF-0006dy-Hf for grub-devel@gnu.org; Wed, 26 Aug 2009 02:31:31 +0200 Date: Wed, 26 Aug 2009 02:31:31 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20090826003131.GC25183@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] UTF-8 to UTF-16 transformation X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2009 00:31:39 -0000 On Mon, Aug 24, 2009 at 09:23:22PM +0200, Vladimir 'phcoder' Serbinenko wrote: > 2009-08-24 Vladimir Serbinenko > > UTF-8 to UTF-16 transformation. > > * conf/common.rmk (pkglib_MODULES): Add utf.mod > (utf_mod_SOURCES): New variable. > (utf_mod_CFLAGS): Likewise. > (utf_mod_LDFLAGS): Likewise. > * include/grub/utf.h: New file. > * lib/utf.c: New file. (Based on grub_utf8_to_ucs4 from kern/misc.c) Sounds like we could end up needing more of this (to other charsets), so why not give this module a generic name to hint as to where it can be added? The conversion functions in kern/misc.c could eventually move there as well, once UTF-8 support becomes optional in the kernel. GNU libc has "iconv" command and "iconv_*" facilities for charset conversion, how about iconv.mod for consistency? > + if ((c & 0x80) == 0x00) > + code = c; > + else if ((c & 0xe0) == 0xc0) These should be macroified. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."