From: Christoph Hellwig <hch@infradead.org>
To: device-mapper development <dm-devel@redhat.com>
Cc: Alasdair G Kergon <agk@redhat.com>, Milan Broz <mbroz@redhat.com>
Subject: Re: Re: New kernel shared snapshots
Date: Tue, 25 Aug 2009 22:02:36 -0400 [thread overview]
Message-ID: <20090826020236.GA5681@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0908251026430.19589@hs20-bc2-1.build.redhat.com>
On Tue, Aug 25, 2009 at 10:43:33AM -0400, Mikulas Patocka wrote:
>
> I mean, if I have function
> static struct some_structure *some_function(int a, int b, int c,
> int d, long long e,
> struct blablabla *p)
Don't align additional paramter lines to after the opening brace,
but always two tabs from column zero, e.g.
static struct some_structure *some_function(int a, int b, int c,
int d, long long e, struct blablabla *p)
also much easier to edit, especially if the function name and/or return
type changes.
And yes, except maye for printks absolutely stick to the 80 column
limit, it's an absolute pain to read otherwise.
next prev parent reply other threads:[~2009-08-26 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 11:24 New kernel shared snapshots Mikulas Patocka
2009-08-19 14:31 ` Jonathan Brassow
2009-08-25 14:43 ` Mikulas Patocka
2009-08-26 2:02 ` Christoph Hellwig [this message]
2009-08-26 2:25 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090826020236.GA5681@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=mbroz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.