From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [Bug #14016] mm/ipw2200 regression Date: Wed, 26 Aug 2009 11:51:18 +0200 Message-ID: <20090826095118.GA26280@cmpxchg.org> References: <_yaHeGjHEzG.A.FIH.7sGlKB@chimera> <84144f020908252309u5cff8afdh2214577ca4db9b5d@mail.gmail.com> <20090826082741.GA25955@cmpxchg.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20090826082741.GA25955-druUgvl0LCNAfugRpC6u6w@public.gmane.org> Sender: kernel-testers-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Pekka Enberg Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Bartlomiej Zolnierkiewicz , Mel Gorman , Andrew Morton , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org On Wed, Aug 26, 2009 at 10:27:41AM +0200, Johannes Weiner wrote: > 64 pages, presumably 256k, for fw->boot_size while current ipw > firmware images have ~188k. I don't know jack squat about this > driver, but given the field name and the struct: > > struct ipw_fw { > __le32 ver; > __le32 boot_size; > __le32 ucode_size; > __le32 fw_size; > u8 data[0]; > }; > > fw->boot_size alone being that big sounds a bit fishy to me. Scrap that, I just noticed the second call to ipw_load_firmware() a few lines later... :) Hannes 'when logic and proportion have fallen sloppy dead...' From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756717AbZHZJwM (ORCPT ); Wed, 26 Aug 2009 05:52:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756686AbZHZJwL (ORCPT ); Wed, 26 Aug 2009 05:52:11 -0400 Received: from cmpxchg.org ([85.214.51.133]:46877 "EHLO cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756678AbZHZJwK (ORCPT ); Wed, 26 Aug 2009 05:52:10 -0400 Date: Wed, 26 Aug 2009 11:51:18 +0200 From: Johannes Weiner To: Pekka Enberg Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Bartlomiej Zolnierkiewicz , Mel Gorman , Andrew Morton , netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [Bug #14016] mm/ipw2200 regression Message-ID: <20090826095118.GA26280@cmpxchg.org> References: <_yaHeGjHEzG.A.FIH.7sGlKB@chimera> <84144f020908252309u5cff8afdh2214577ca4db9b5d@mail.gmail.com> <20090826082741.GA25955@cmpxchg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090826082741.GA25955@cmpxchg.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 26, 2009 at 10:27:41AM +0200, Johannes Weiner wrote: > 64 pages, presumably 256k, for fw->boot_size while current ipw > firmware images have ~188k. I don't know jack squat about this > driver, but given the field name and the struct: > > struct ipw_fw { > __le32 ver; > __le32 boot_size; > __le32 ucode_size; > __le32 fw_size; > u8 data[0]; > }; > > fw->boot_size alone being that big sounds a bit fishy to me. Scrap that, I just noticed the second call to ipw_load_firmware() a few lines later... :) Hannes 'when logic and proportion have fallen sloppy dead...' From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id 17CB66B0062 for ; Wed, 26 Aug 2009 05:52:29 -0400 (EDT) Date: Wed, 26 Aug 2009 11:51:18 +0200 From: Johannes Weiner Subject: Re: [Bug #14016] mm/ipw2200 regression Message-ID: <20090826095118.GA26280@cmpxchg.org> References: <_yaHeGjHEzG.A.FIH.7sGlKB@chimera> <84144f020908252309u5cff8afdh2214577ca4db9b5d@mail.gmail.com> <20090826082741.GA25955@cmpxchg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090826082741.GA25955@cmpxchg.org> Sender: owner-linux-mm@kvack.org To: Pekka Enberg Cc: "Rafael J. Wysocki" , Linux Kernel Mailing List , Kernel Testers List , Bartlomiej Zolnierkiewicz , Mel Gorman , Andrew Morton , netdev@vger.kernel.org, linux-mm@kvack.org List-ID: On Wed, Aug 26, 2009 at 10:27:41AM +0200, Johannes Weiner wrote: > 64 pages, presumably 256k, for fw->boot_size while current ipw > firmware images have ~188k. I don't know jack squat about this > driver, but given the field name and the struct: > > struct ipw_fw { > __le32 ver; > __le32 boot_size; > __le32 ucode_size; > __le32 fw_size; > u8 data[0]; > }; > > fw->boot_size alone being that big sounds a bit fishy to me. Scrap that, I just noticed the second call to ipw_load_firmware() a few lines later... :) Hannes 'when logic and proportion have fallen sloppy dead...' -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org